JBTM-3911 Replace synchronized in favor of Reentrant Lock

in LRAService joinLRA method

Author: marcosgopen

rts/lra/coordinator/src/main/java/io/narayana/lra/coordinator/domain/model/LongRunningAction.java

@@ -726,23 +726,32 @@ protected LRAStatus toLRAStatus(int atomicActionStatus) {
 
     public LRAParticipantRecord enlistParticipant(URI coordinatorUrl, String participantUrl, String recoveryUrlBase,
                                                   long timeLimit, String compensatorData) throws UnsupportedEncodingException {
-        LRAParticipantRecord participant = findLRAParticipant(participantUrl, false);
-
-        if (participant != null) {
-            participant.setCompensatorData(compensatorData);
-            return participant; // must have already been enlisted
+        ReentrantLock lock = tryLockTransaction();
+        if (lock == null) {
+            LRALogger.i18nLogger.warn_enlistment();
+            return null;
         }
-
-        participant = doEnlistParticipant(coordinatorUrl, participantUrl, recoveryUrlBase,
-                timeLimit, compensatorData);
-
-        if (participant != null) {
-            // need to remember that there is a new participant
-            deactivate(); // if it fails the superclass will have logged a warning
-            savedIntentionList = true; // need this clean up if the LRA times out
+        else {
+            try {
+                LRAParticipantRecord participant = findLRAParticipant(participantUrl, false);
+                if (participant != null) {
+                    participant.setCompensatorData(compensatorData);
+                    return participant; // must have already been enlisted
+                }
+                participant = doEnlistParticipant(coordinatorUrl, participantUrl, recoveryUrlBase, timeLimit,
+                        compensatorData);
+                if (participant != null) {
+                    // need to remember that there is a new participant
+                    deactivate(); // if it fails the superclass will have logged a warning
+                    savedIntentionList = true; // need this clean up if the LRA times out
+                }
+                return participant;
+            }
+            finally {
+                lock.unlock();
+            }
         }
 
-        return participant;
     }
 
     private LRAParticipantRecord doEnlistParticipant(URI coordinatorUrl, String participantUrl, String recoveryUrlBase,

rts/lra/coordinator/src/main/java/io/narayana/lra/coordinator/domain/service/LRAService.java

@@ -328,7 +328,7 @@ public int leave(URI lraId, String compensatorUrl) {
         }
     }
 
-    public synchronized int joinLRA(StringBuilder recoveryUrl, URI lra, long timeLimit,
+    public int joinLRA(StringBuilder recoveryUrl, URI lra, long timeLimit,
                                     String compensatorUrl, String linkHeader, String recoveryUrlBase,
                                     StringBuilder compensatorData) {
         if (lra ==  null) {