Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(download): use architecture-specific artifact names #4

Merged
merged 1 commit into from
Nov 22, 2024
Merged

fix(download): use architecture-specific artifact names #4

merged 1 commit into from
Nov 22, 2024

Conversation

sid-maddy
Copy link
Contributor

Legacy release artifacts were deprecated in JohnnyMorganz/StyLua#911

@jc00ke
Copy link
Owner

jc00ke commented Nov 18, 2024

Hi @sid-maddy, thanks for the PR! I'm guessing you ran a formatter, which is making the changes a bit noisy. Any chance you could rework this to only contain the necessary changes? I appreciate the typo fix and as long as shellfmt passes, I don't really mind about the format.

@sid-maddy
Copy link
Contributor Author

I'm guessing you ran a formatter, which is making the changes a bit noisy. Any chance you could rework this to only contain the necessary changes?

Sorry, I have shfmt configured to format with different settings. I've now run the scripts/shellcheck.bash and scripts/shfmt.bash scripts.

@jc00ke jc00ke merged commit 5b8d944 into jc00ke:main Nov 22, 2024
4 checks passed
@jc00ke
Copy link
Owner

jc00ke commented Nov 22, 2024

Thanks @sid-maddy! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants