Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for merge request approvals api #49

Closed
jnovick opened this issue Mar 21, 2018 · 4 comments
Closed

Add support for merge request approvals api #49

jnovick opened this issue Mar 21, 2018 · 4 comments
Milestone
3.0.0

Comments

@jnovick
Copy link
Contributor

jnovick commented Mar 21, 2018

GitLab 10.6 will be release tomorrow (3/22/18) and includes new endpoints for merge request approvals. I just want to submit a feature request for these routes to be added. https://docs.gitlab.com/ee/api/merge_request_approvals.html
@jdalrymple
Copy link
Owner

jdalrymple commented Mar 21, 2018 •
edited
Loading

Just looking over the docs. How are these changes for the library

Projects

  • showApprovals (or approvals) -> gets config
  • editApprovals -> update config
  • editApprovers -> update approvers

Merge Requests

  • showApprovals (or approvals) -> gets config
  • editApprovals -> update config
  • editApprovers -> update approvers
  • approve -> approve MR
  • unapprove -> unapprove MR

@jnovick
Copy link
Contributor Author

jnovick commented Mar 21, 2018

I think that would be great! You responded ridiculously fast. I appreciate it. 👍

@jdalrymple
Copy link
Owner

jdalrymple commented Mar 21, 2018 •
edited
Loading

Released in v3.0.0-rc.3

@jdalrymple jdalrymple added this to the 3.0.0 milestone Mar 24, 2018
@MunifTanjim MunifTanjim mentioned this issue Jun 6, 2018
Open
@Sryther
Copy link

Sryther commented Feb 9, 2023

It looks like the approvals method is not in the @gitbreaker/node v35.8.0 at least.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.0.0
Development

No branches or pull requests
3 participants
@jdalrymple @Sryther @jnovick