Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix MergeRequestSchema.closed_at property type #3381

Merged
merged 1 commit into from
Aug 17, 2023
Merged

Fix MergeRequestSchema.closed_at property type #3381

merged 1 commit into from
Aug 17, 2023

Conversation

kouak
Copy link
Contributor

@kouak kouak commented Aug 17, 2023

This PR fixes MergeRequestSchema.closed_at property type which was wrongly typed as a UserSchema.

This should be string | null, with the timestamp of when the MR was closed.

@jdalrymple jdalrymple added the type:bug Changes fix a minor bug label Aug 17, 2023
@jdalrymple jdalrymple merged commit 98ca75a into jdalrymple:main Aug 17, 2023
1 of 2 checks passed
@kouak kouak deleted the fix-merge-request-typing branch August 17, 2023 16:33
@jdalrymple
Copy link
Owner

🚀 PR was released in 39.11.0 🚀

@jdalrymple jdalrymple added the released This issue/pull request has been released. label Aug 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
released This issue/pull request has been released. type:bug Changes fix a minor bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kouak @jdalrymple