This repository has been archived by the owner on Jan 7, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Rotation issue Fix #221
Open
Lawgrin
wants to merge
12
commits into
jdamcd:master
Choose a base branch
from
Lawgrin:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Rotation issue Fix #221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes issue where the savedUri rotation was incorrect
A problem occurred configuring project ':example'.
Please update to use the latest build tools |
Changes buildToolsVersion to 23.0.2
Changes build tools version again, to 23.0.1 Can’t believe that it hasn’t been updated
Added the withMinSize function to allow for min size will also throw exception/error if the selected image is less then the given amount
# Conflicts: # build.gradle # lib/src/main/java/com/soundcloud/android/crop/Crop.java
# Conflicts: # build.gradle # lib/src/main/java/com/soundcloud/android/crop/Crop.java
5 lint errors removed
Lint and travis are conflicting, please sort this out |
Replaces almost all icons. Added "disable 'Registered', 'IconDensities'" for lint ignore Updated travis CI
@jdamcd Please review as there is nothing more for me to fix. Update your travis CI to the latest build tools |
@jdamcd , @Lawgrin Any update on this pull request with this rotation fix. Please revert if you have any comments. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue where the savedUri rotation was incorrect
Along with builder and sdk updates