From 25306a2bcb72f1bbe572a96f1f2b6b6e83109094 Mon Sep 17 00:00:00 2001 From: ShunLiu-NOAA Date: Wed, 4 Oct 2023 16:03:47 -0400 Subject: [PATCH 1/2] Turn off enspread reg (#635) In cplr_get_fv3_regional_ensperts.f90, "write_ens_sprd=.true." is hard-coded and overwrites the values in namelist. write_ens_sprd=.true." should be removed. Fixes #634 **Type of change** Please delete options that are not relevant. - [x] Bug fix (non-breaking change which fixes an issue) --- src/gsi/cplr_get_fv3_regional_ensperts.f90 | 1 - 1 file changed, 1 deletion(-) diff --git a/src/gsi/cplr_get_fv3_regional_ensperts.f90 b/src/gsi/cplr_get_fv3_regional_ensperts.f90 index 5a3e72970d..5b8fb153b6 100644 --- a/src/gsi/cplr_get_fv3_regional_ensperts.f90 +++ b/src/gsi/cplr_get_fv3_regional_ensperts.f90 @@ -684,7 +684,6 @@ subroutine get_fv3_regional_ensperts_run(this,en_perts,nelen,ps_bar) enddo ! it 4d loop ! CALCULATE ENSEMBLE SPREAD - write_ens_sprd=.true. if(write_ens_sprd ) then call this%ens_spread_dualres_regional(mype,en_perts,nelen) call mpi_barrier(mpi_comm_world,ierror) ! do we need this mpi_barrier here? From 978b7e76a53a6d5814efac17b212f5d788c7a5c3 Mon Sep 17 00:00:00 2001 From: Ming Hu Date: Fri, 6 Oct 2023 14:08:09 -0600 Subject: [PATCH 2/2] A bug fix in setupps (#638) A bug is found in setupps and setupspd: un-used observation is also marked as 1 in "Analysis_Usage_Flag". Remove a print statement in rfv3io to simply stdout. This is PR fixes #637 --- src/gsi/gsi_rfv3io_mod.f90 | 3 --- src/gsi/setupps.f90 | 2 +- src/gsi/setupspd.f90 | 2 +- 3 files changed, 2 insertions(+), 5 deletions(-) diff --git a/src/gsi/gsi_rfv3io_mod.f90 b/src/gsi/gsi_rfv3io_mod.f90 index 6d16be7c13..d0cbd3afbd 100644 --- a/src/gsi/gsi_rfv3io_mod.f90 +++ b/src/gsi/gsi_rfv3io_mod.f90 @@ -2610,9 +2610,6 @@ subroutine gsi_fv3ncdf_readuv(grd_uv,ges_u,ges_v,fv3filenamegin) members(mm1) = mype endif - write(6,115)mype,kbgn,kend,procuse -115 format('gsi_fv3ncdf_readuv: mype ',i6,' has kbgn,kend= ',2(i6,1x),' set procuse ',l7) - call mpi_allreduce(members,members_read,npe,mpi_integer,mpi_max,mpi_comm_world,ierror) nread=0 diff --git a/src/gsi/setupps.f90 b/src/gsi/setupps.f90 index 118ccb45d2..f376f9ffde 100644 --- a/src/gsi/setupps.f90 +++ b/src/gsi/setupps.f90 @@ -904,7 +904,7 @@ subroutine contents_netcdf_diag_(odiag) if(muse(i)) then call nc_diag_metadata("Analysis_Use_Flag", 1.0_r_single ) else - call nc_diag_metadata("Analysis_Use_Flag", 1.0_r_single ) + call nc_diag_metadata("Analysis_Use_Flag", -1.0_r_single ) endif call nc_diag_metadata_to_single("Errinv_Input", errinv_input ) diff --git a/src/gsi/setupspd.f90 b/src/gsi/setupspd.f90 index 64366394cb..150799bf2c 100644 --- a/src/gsi/setupspd.f90 +++ b/src/gsi/setupspd.f90 @@ -962,7 +962,7 @@ subroutine contents_netcdf_diag_(odiag) if(muse(i)) then call nc_diag_metadata("Analysis_Use_Flag", 1.0_r_single ) else - call nc_diag_metadata("Analysis_Use_Flag", 1.0_r_single ) + call nc_diag_metadata("Analysis_Use_Flag", -1.0_r_single ) endif call nc_diag_metadata_to_single("Errinv_Input",errinv_input )