Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

git-pull request wrong argument type IO (V1.0.2) #72

Closed
leckylao opened this issue Sep 5, 2012 · 7 comments
Closed

git-pull request wrong argument type IO (V1.0.2) #72

leckylao opened this issue Sep 5, 2012 · 7 comments

Comments

@leckylao
Copy link

leckylao commented Sep 5, 2012

Authorizing xxxx to work with https://api.github.com.
Your GitHub password: /Users/onebigswitch/.rvm/gems/ruby-1.9.3-p194/gems/highline-1.6.13/lib/highline/system_extensions.rb:74:in getattr': wrong argument type IO (expected Hash) (TypeError) from /Users/onebigswitch/.rvm/gems/ruby-1.9.3-p194/gems/highline-1.6.13/lib/highline/system_extensions.rb:74:inget_character'
from /Users/onebigswitch/.rvm/gems/ruby-1.9.3-p194/gems/highline-1.6.13/lib/highline.rb:822:in get_single_character' from /Users/onebigswitch/.rvm/gems/ruby-1.9.3-p194/gems/highline-1.6.13/lib/highline.rb:855:inget_response'
from /Users/onebigswitch/.rvm/gems/ruby-1.9.3-p194/gems/highline-1.6.13/lib/highline.rb:260:in ask' from /Users/onebigswitch/.rvm/gems/ruby-1.9.3-p194/gems/git-process-1.0.2/lib/git-process/github_service.rb:128:inpassword'

Looks like https://github.com/jdigger/git-process/blob/master/lib/git-process/github_service.rb#L130 causing the problem. By commenting it out then I am able to type password. But then it follow by another error:

Your GitHub password: xxxxxxxx
/Users/onebigswitch/.rvm/gems/ruby-1.9.3-p194/gems/json-1.7.5/lib/json/ext/parser.bundle: undefined class/module Encoding (ArgumentError)
from /System/Library/Frameworks/Ruby.framework/Versions/1.8/usr/lib/ruby/1.8/rubygems/custom_require.rb:31:in require' from /Users/onebigswitch/.rvm/gems/ruby-1.9.3-p194/gems/json-1.7.5/lib/json/ext.rb:13 from /System/Library/Frameworks/Ruby.framework/Versions/1.8/usr/lib/ruby/1.8/rubygems/custom_require.rb:31:ingem_original_require'
from /System/Library/Frameworks/Ruby.framework/Versions/1.8/usr/lib/ruby/1.8/rubygems/custom_require.rb:31:in require' from /Users/onebigswitch/.rvm/gems/ruby-1.9.3-p194/gems/json-1.7.5/lib/json.rb:58 from /System/Library/Frameworks/Ruby.framework/Versions/1.8/usr/lib/ruby/1.8/rubygems/custom_require.rb:31:ingem_original_require'
from /System/Library/Frameworks/Ruby.framework/Versions/1.8/usr/lib/ruby/1.8/rubygems/custom_require.rb:31:in require' from /Users/onebigswitch/.rvm/gems/ruby-1.9.3-p194/gems/faraday_middleware-0.8.8/lib/faraday_middleware/request/encode_json.rb:16 from /Users/onebigswitch/.rvm/gems/ruby-1.9.3-p194/gems/faraday-0.8.1/lib/faraday/middleware.rb:14:independency'
from /Users/onebigswitch/.rvm/gems/ruby-1.9.3-p194/gems/faraday_middleware-0.8.8/lib/faraday_middleware/request/encode_json.rb:15
from /Users/onebigswitch/.rvm/gems/ruby-1.9.3-p194/gems/faraday_middleware-0.8.8/lib/faraday_middleware.rb:23
from /Users/onebigswitch/.rvm/gems/ruby-1.9.3-p194/gems/faraday-0.8.1/lib/faraday.rb:66:in call' from /Users/onebigswitch/.rvm/gems/ruby-1.9.3-p194/gems/faraday-0.8.1/lib/faraday.rb:66:inlookup_middleware'
from /Users/onebigswitch/.rvm/gems/ruby-1.9.3-p194/gems/faraday-0.8.1/lib/faraday/builder.rb:146:in use_symbol' from /Users/onebigswitch/.rvm/gems/ruby-1.9.3-p194/gems/faraday-0.8.1/lib/faraday/builder.rb:100:inrequest'
from /Users/onebigswitch/.rvm/gems/ruby-1.9.3-p194/gems/git-process-1.0.2/lib/git-process/github_client.rb:45:in connection' from /Users/onebigswitch/.rvm/gems/ruby-1.9.3-p194/gems/faraday-0.8.1/lib/faraday/connection.rb:48:ininitialize'
from /Users/onebigswitch/.rvm/gems/ruby-1.9.3-p194/gems/faraday-0.8.1/lib/faraday.rb:11:in new' from /Users/onebigswitch/.rvm/gems/ruby-1.9.3-p194/gems/faraday-0.8.1/lib/faraday.rb:11:innew'
from /Users/onebigswitch/.rvm/gems/ruby-1.9.3-p194/gems/git-process-1.0.2/lib/git-process/github_client.rb:43:in connection' from /Users/onebigswitch/.rvm/gems/ruby-1.9.3-p194/gems/octokit-1.4.0/lib/octokit/request.rb:40:inold_request'
from /Users/onebigswitch/.rvm/gems/ruby-1.9.3-p194/gems/git-process-1.0.2/lib/git-process/github_client.rb:82:in `request'

I love to use git-process, any help is needed.

@jdigger
Copy link
Owner

jdigger commented Sep 6, 2012

Thanks for the report, Lecky. Most of the project's usage has been on the system Ruby that OSX comes with (1.8.7), so I expect that it's a difference that occurs with 1.9.3. (There have been several bugs that appear with 1.9.3.) I'll see what I can track down.

@leckylao
Copy link
Author

leckylao commented Sep 6, 2012

Putting some docs about the limitation for now would be good ;)

Sent from my iPhone

Regards,
Lecky Lao

On 07/09/2012, at 8:43 AM, Jim Moore notifications@github.com wrote:

Thanks for the report, Lecky. Most of the project's usage has been on the system Ruby that OSX comes with (1.8.7), so I expect that it's a difference that occurs with 1.9.3. (There have been several bugs that appear with 1.9.3.) I'll see what I can track down.


Reply to this email directly or view it on GitHub.

@jdigger
Copy link
Owner

jdigger commented Sep 7, 2012

I'm afraid I can't reproduce this. I've tried 1.8.7 and 1.9.3 on both OSX and Windows, and it works fine.

That said, I have made some changes to not include some gems (like ruby-termios) that may have the side-effect of resolving this. Try version 1.0.3 (which I just pushed to RubyForge).

@leckylao
Copy link
Author

leckylao commented Sep 7, 2012

Thx Jim. I will try to upgrade it . Forgot to mention that I am using RVM. So currently I just switch to 1.8.7 for using git-process and switch back to 1.9.3 for development.....

@jdigger
Copy link
Owner

jdigger commented Sep 11, 2012

I have gotten a similar error (in 1.8.7):

Authorizing jdigger to work with http://github.com.
Your GitHub password: You must enter a valid HighLine::String.
?  You must enter a valid HighLine::String.
?  You must enter a valid HighLine::String.
?  You must enter a valid HighLine::String.

@leckylao
Copy link
Author

So that's issue with using RVM?

@jdigger
Copy link
Owner

jdigger commented Sep 11, 2012

Not certain that it's the same bug, but appears to be.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants