Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Android support fixing the arrow #36

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

gyfelton
Copy link

@gyfelton gyfelton commented Sep 29, 2017

The main problem of Android is that it does not allow bleed out subview to be displayed, unlike iOS

The fix here is to make the Popover View (styles.popover) larger so that arrow can be displayed

To achieve this, not only margin is added based on the position of the arrow, the followings are also done to help achieve the final result:

  1. if auto placement is used, then during the geometry calculation the right placement will be returned and updated internally (the placement state)
  2. if placement is bottom or right, then content itself will be moved (in terms of left and top property) to accommodate the arrow

Tested in our app and it works for us.

I cannot create a android project due to time constrain, maybe someone can help?

@zhaoqianpeng123
Copy link

Hi, can you tell me how to fix it , follow your step ,i can not how to modify ,thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants