Add Android support fixing the arrow #36
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main problem of Android is that it does not allow bleed out subview to be displayed, unlike iOS
The fix here is to make the Popover View (
styles.popover
) larger so that arrow can be displayedTo achieve this, not only margin is added based on the position of the arrow, the followings are also done to help achieve the final result:
auto
placement is used, then during the geometry calculation the right placement will be returned and updated internally (theplacement
state)left
andtop
property) to accommodate the arrowTested in our app and it works for us.
I cannot create a android project due to time constrain, maybe someone can help?