Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

'module' object has no attribute 'get_deleted' #52

Closed
LegoStormtroopr opened this issue Dec 26, 2015 · 5 comments
Closed

'module' object has no attribute 'get_deleted' #52

LegoStormtroopr opened this issue Dec 26, 2015 · 5 comments

Comments

@LegoStormtroopr
Copy link
Contributor

Changes to support django-reversion 1.10 have broken some code here:

https://github.com/jedie/django-reversion-compare/blob/master/reversion_compare/compare.py#L165

causes this error:

AttributeError at /action/compare
'module' object has no attribute 'get_deleted'

Looks like in 1.10 that was moved to reversion.revisions. Am checking this out
@LegoStormtroopr LegoStormtroopr changed the title https://github.com/jedie/django-reversion-compare/blob/master/reversion_compare/compare.py#L165 'module' object has no attribute 'get_deleted' Dec 26, 2015
@jedie
Copy link
Owner

jedie commented Dec 26, 2015

Thanks for reporting!

Would be great if you contribute a pull request to fix this ;)

@LegoStormtroopr
Copy link
Contributor Author

Already working on it ;)
On 26 Dec 2015 9:50 pm, "Jens Diemer" notifications@github.com wrote:

Thanks for reporting!

Would be great to contribute a pull request to fix this ;)

—
Reply to this email directly or view it on GitHub
#52 (comment)
.

LegoStormtroopr added a commit to LegoStormtroopr/django-reversion-compare that referenced this issue Dec 27, 2015
@LegoStormtroopr
fixed jedie#52
df7b656
@LegoStormtroopr
Copy link
Contributor Author

This is being covered in #51

@vdboor
Copy link
Contributor

vdboor commented Jan 14, 2016

@jedie : would it be possible to merge #51? That would fix django-reversion 1.10 support, while preserving compatibility with earlier versions

@LegoStormtroopr
Copy link
Contributor Author

Closing this as #51 did it better.

LegoStormtroopr added a commit to LegoStormtroopr/django-reversion-compare that referenced this issue Feb 1, 2016
@LegoStormtroopr
fixed jedie#52
d5721b7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jedie @vdboor @LegoStormtroopr