[shared_preferences web/macos] remove unused onMethodCall methods (fl…

…utter#2412)
jefflim-google · Dec 12, 2019 · 509bd31 · 509bd31
1 parent 1d16548
commit 509bd31
Show file tree

Hide file tree

Showing 6 changed files with 11 additions and 14 deletions.
diff --git a/packages/shared_preferences/shared_preferences_macos/CHANGELOG.md b/packages/shared_preferences/shared_preferences_macos/CHANGELOG.md
@@ -1,3 +1,7 @@
+## 0.0.1+2
+
+* Remove unused onMethodCall method.
+
 ## 0.0.1+1
 
 * Add an android/ folder with no-op implementation to workaround https://github.com/flutter/flutter/issues/46898.

diff --git a/...c/main/java/io/flutter/plugins/shared_preferences_macos/SharedPreferencesMacosPlugin.java b/...c/main/java/io/flutter/plugins/shared_preferences_macos/SharedPreferencesMacosPlugin.java
@@ -1,21 +1,15 @@
 package io.flutter.plugins.shared_preferences_macos;
 
 import io.flutter.embedding.engine.plugins.FlutterPlugin;
-import io.flutter.plugin.common.MethodCall;
-import io.flutter.plugin.common.MethodChannel.MethodCallHandler;
-import io.flutter.plugin.common.MethodChannel.Result;
 import io.flutter.plugin.common.PluginRegistry.Registrar;
 
 /** SharedPreferencesMacosPlugin */
-public class SharedPreferencesMacosPlugin implements FlutterPlugin, MethodCallHandler {
+public class SharedPreferencesMacosPlugin implements FlutterPlugin {
   @Override
   public void onAttachedToEngine(FlutterPluginBinding flutterPluginBinding) {}
 
   public static void registerWith(Registrar registrar) {}
 
-  @Override
-  public void onMethodCall(MethodCall call, Result result) {}
-
   @Override
   public void onDetachedFromEngine(FlutterPluginBinding binding) {}
 }
diff --git a/packages/shared_preferences/shared_preferences_macos/pubspec.yaml b/packages/shared_preferences/shared_preferences_macos/pubspec.yaml
@@ -1,6 +1,6 @@
 name: shared_preferences_macos
 description: macOS implementation of the shared_preferences plugin.
-version: 0.0.1+1
+version: 0.0.1+2
 homepage: https://github.com/flutter/plugins/tree/master/packages/shared_preferences/shared_preferences_macos
 
 flutter:

diff --git a/packages/shared_preferences/shared_preferences_web/CHANGELOG.md b/packages/shared_preferences/shared_preferences_web/CHANGELOG.md
@@ -1,3 +1,7 @@
+# 0.1.2+2
+
+* Remove unused onMethodCall method.
+
 # 0.1.2+1
 
 * Add an android/ folder with no-op implementation to workaround https://github.com/flutter/flutter/issues/46898.

diff --git a/...d/src/main/java/io/flutter/plugins/shared_preferences_web/SharedPreferencesWebPlugin.java b/...d/src/main/java/io/flutter/plugins/shared_preferences_web/SharedPreferencesWebPlugin.java
@@ -1,8 +1,6 @@
 package io.flutter.plugins.shared_preferences_web;
 
 import io.flutter.embedding.engine.plugins.FlutterPlugin;
-import io.flutter.plugin.common.MethodCall;
-import io.flutter.plugin.common.MethodChannel.Result;
 import io.flutter.plugin.common.PluginRegistry.Registrar;
 
 /** SharedPreferencesWebPlugin */
@@ -12,9 +10,6 @@ public void onAttachedToEngine(FlutterPluginBinding flutterPluginBinding) {}
 
   public static void registerWith(Registrar registrar) {}
 
-  @Override
-  public void onMethodCall(MethodCall call, Result result) {}
-
   @Override
   public void onDetachedFromEngine(FlutterPluginBinding binding) {}
 }
diff --git a/packages/shared_preferences/shared_preferences_web/pubspec.yaml b/packages/shared_preferences/shared_preferences_web/pubspec.yaml
@@ -1,7 +1,7 @@
 name: shared_preferences_web
 description: Web platform implementation of shared_preferences
 homepage: https://github.com/flutter/plugins/tree/master/packages/shared_preferences/shared_preferences_web
-version: 0.1.2+1
+version: 0.1.2+2
 
 flutter:
   plugin: