Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Making use of service resource over the low level client for SQS. #42

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

hjpotter92
Copy link
Contributor

References #39.

Also adds syntax highlight for readme.

References jegesh#39.

Signed-off-by: hjpotter92 <hjpotter92+github@gmail.com>
Signed-off-by: hjpotter92 <hjpotter92+github@gmail.com>
Signed-off-by: hjpotter92 <hjpotter92+github@gmail.com>
 * fetching queue URL by name
 * validating `AWS_ACCOUNT_ID` environment variable
 * checking length of messages

Signed-off-by: hjpotter92 <hjpotter92+github@gmail.com>
@jegesh
Copy link
Owner

jegesh commented Aug 30, 2021

Hi! Thanks for dedicated time and energy to improving this project!

Two short questions - 1. what is the tangible advantage to using resource over client in this case?
2. Have you tested the new code, and how?

@jegesh
Copy link
Owner

jegesh commented Aug 30, 2021

And sorry for the loooooong delay!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants