Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

site.github.url may cause builds to fail—and is undocumented #42

Closed
kansaichris opened this issue Sep 8, 2014 · 2 comments · Fixed by #43
Closed

site.github.url may cause builds to fail—and is undocumented #42

kansaichris opened this issue Sep 8, 2014 · 2 comments · Fixed by #43
Labels
frozen-due-to-age

Comments

@kansaichris
Copy link
Contributor

#26 added site.github.url as a configuration option for setting redirect prefixes, but that option will conflict with any other value of github in _config.yml (example). Shouldn't we handle an existing site.github value—without a corresponding site.github.url value—a bit more gracefully? At the very least, we should really document this behavior—I'm pretty sure that it's going to cause problems for anyone who isn't actively watching pull requests on this repository.

@akoeplinger @parkr @benbalter Could I get your 👀 on this?
@parkr
Copy link
Member

parkr commented Sep 8, 2014

D'oh! Very good point. We should fix this. 👍

@kansaichris kansaichris mentioned this issue Sep 8, 2014
Closed
akoeplinger added a commit to akoeplinger/jekyll-redirect-from that referenced this issue Sep 8, 2014
@akoeplinger
Fixed error when the site.github config key is set, but site.github.u…
9f102d0 
…rl is not

Fixes jekyll#42
@akoeplinger akoeplinger mentioned this issue Sep 8, 2014
Merged
@akoeplinger
Copy link
Contributor

I assumed that GitHub Pages overwrites anything in site.github with its metadata, but apparently it does not and we need to fallback too.

PR: #43

akoeplinger added a commit to akoeplinger/jekyll-redirect-from that referenced this issue Sep 8, 2014
@akoeplinger
Fixed error when the site.github config key is set, but site.github.u…
e6c6e87 
…rl is not

Fixes jekyll#42
@parkr parkr closed this as completed in #43 Sep 8, 2014
@jekyll jekyll locked and limited conversation to collaborators Feb 27, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
frozen-due-to-age
Projects
None yet
Milestone
No milestone
4 participants
@parkr @akoeplinger @kansaichris @jekyllbot