Fixed error when the site.github config key is set, but site.github.url is not #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -59,7 +59,8 @@ def redirect_prefix(site) | |||
| end | |||
|
|
|||
| def config_github_url(site) | |||
| site.config.fetch('github', Hash.new).fetch('url', nil) | |||
| config_github = site.config.fetch('github', Hash.new) | |||
| config_github.respond_to?('fetch') ? config_github.fetch('url', nil) : nil | |||
There was a problem hiding this comment.
Just out of curiosity, do you think it would be cleaner to write this with an inline if statement?
config_github.fetch('url', nil) if config_github.respond_to?('fetch')There was a problem hiding this comment.
Oh, duh, don't mind me—you need the nil return value here. 😊
Sorry, I think my suggestion actually would return nil if config_github.respond_to?('fetch') returned false.
There was a problem hiding this comment.
Yeah, your suggestion works too. I don't have a preference, but I don't do much Ruby, so not sure which one is considered more idiomatic 😄
There was a problem hiding this comment.
Maybe @parkr would know...
There was a problem hiding this comment.
I'd probably write:
def config_github_url(site)
github_config = site.config['github']
github_config['url'] if github_config.is_a?(Hash)
end
|
Wow, that was fast. Thanks for opening this, @akoeplinger! |
akoeplinger
force-pushed
the
fix-github-url
branch
from
9f102d0
to
e6c6e87
Compare
parkr
added a commit
that referenced
this pull request
Sep 8, 2014
parkr
added a commit
that referenced
this pull request
Sep 8, 2014
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #42