Generate redirect_to content for collections

[gjtorikian]

This should close #45, when the tests pass. Looks like redirect_to pages are not being generated for collections.

/cc @parkr Will probably necessitate another (minor) bump.

[gjtorikian]

Yeah, no matter what, it seems like self.content = self.output is not being set, which renders redirect_to broken.

[parkr]

That self stuff is on the redirect page, not on the document, so it should be fine. Maybe it's not getting the correct URL or isn't accessing the data properly?

[parkr]

Is site.read run before these tests run? Or site.process? I forget.

[parkr]

It looks like doc is nil.

[parkr]

Use relative_path here

[gjtorikian]

I've just pushed up a change to sort of demonstrate what I mean.

With redirect_to, we want the same URL as the document, just different contents; the contents should be a redirect out to some other URL. With a page or a post, this appears to be fine, we've been testing that all along.

But with a collection, somehow, the item's original contents remain. Right now, "a" fix for this is to overwrite item.content = item.output to be the RedirectPage information. This does not seem ideal, though. I don't know why collections are being processed differently. It would be nice if I could just "remove" the document from site.docs_to_write and stick to continuing with site.pages << redirect_page, but nothing I tried seemed to work.

[gjtorikian]

Guh, maybe this is impossible. The "HTML" that gets generated looks like this:

<p>&lt;!DOCTYPE html&gt;
&lt;meta charset=utf-8&gt;</p>
<title>Redirecting...</title>
<p>&lt;link rel=canonical href=”http://www.zombo.com”&gt;
&lt;meta http-equiv=refresh content=”0; url=http://www.zombo.com”&gt;</p>
<h1>Redirecting...</h1>
<p><a href="http://www.zombo.com">Click here if you are not redirected.</a>
<script>location='http://www.zombo.com'</script></p>

The smart curly quotes are also bothering Ruby 1.9.3.

[parkr]

For the redirect_to file, make it an HTML page instead of a MD page.

[gjtorikian]

For the redirect_to class, make it an HTML page instead of a MD page.

Of course! Thanks for the hint. Rebased some of my commits above for a cleaner history, and added a note as such to the README about this.

[gjtorikian]

BTW, everything I hate about programming is encapsulated in this PR.

"Oh I'll just do one quick thing this afternoon...."

[parkr]

BTW, everything I hate about programming is encapsulated in this PR.

I'm 😦 but also 😆 so hard. ❤️ for sticking through it.

This is looking really good to me. What do you think?

[gjtorikian]

If it looks good to you that's great for me. I don't think this needs another security review, so you can probably just update the PR on pages-gem, and I'll merge and release.

[parkr]

LET'S DO THIS THANG