Exclude redirect pages from sitemap #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems pretty good. @benbalter ? |
|
👍 was actually just noticing this myself the other day, but didn't realize it was such an easy fix. Nice work. |
|
Tested to make sure the inverse was true (if we don't change this code, that the sitemap does indeed include the redirect pages). Merged and will release v0.8.0 now! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a page is nothing more than a redirect to another page, it should be excluded from the sitemap.
There are other ways this could be done (like coordinating priority), but I think since we want a specific result it would be best to take specific action.
Please look over my code before merging; this is outside of my wheelhouse.
Fixes jekyll/jekyll-sitemap#75