Include Content-Security-Policy as meta tag, assert against violations in tests and remove deprecated referrer policy #156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
jelhan
commented
Jan 2, 2019
•
jelhan
commented
- CSP is included in build as meta tag.
- Deprecated referrer policy removed.
- Fixes existing CSP violations.
- Throw in tests if CSP is violated.
|
Chart.js has added a CSP violation in one of it's latest versions. It should be fixed after chartjs/Chart.js#5952 is merged. |
All major browsers support standard by now. Only IE11 has limited support for X-Content-Security-Policy. But that support is limited to sandbox directive, which isn't used by Croodle.
Having both a Content-Security-Policy (CSP) in meta tag and per header works fine together. They are merged and the strongest one is applied. It makes Croodle safer for all users even if the hoster does not apply CSP for some reason (e.g. they can't set custom headers). It's still a good idea to recommend using a CSP header cause that ones are applied earlier - even so this shouldn't be a problem cause we ensure that CSP meta tag is present before any other link, style or script element.
…t loader assertion
This one requires a migration from deprecated ember-cli-qunit to ember-qunit. ember-qunit throws in Unit tests cause they interact with runloop but didn't awaited everything to finish. An assertion was thrown therefor: > Assertion Failed: expected container not to be destroyed
jelhan
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.