Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[iOS] Admin Dashboard - API Keys #1284

Merged
merged 11 commits into from
Oct 25, 2024
Merged

Conversation

JPKribs
Copy link
Member

@JPKribs JPKribs commented Oct 20, 2024

Summary

This view allows users to manage API keys (create, delete, or copy them) for the Jellyfin server. While API key management might not be a frequent necessity for every user, it was a straightforward addition, so it made sense to include it for those who need it. The view offers a simple interface for handling keys, making it easy to add a new key, remove old ones, or copy existing keys to the clipboard.

  • Selecting a key will copy it to your clipboard.
  • Swiping a key prompt you to confirm if you want to delete it. Confirming will delete it.
  • Selecting Add will prompt you for the Application name for this API Key, then creates the key.

Screenshots

View View Screenshot
Delete Delete Screenshot
Select Select Screenshot
Added Added Screenshot
Add Add Screenshot

@JPKribs
Copy link
Member Author

JPKribs commented Oct 21, 2024

In the same line of thinking as this: #1277 (comment), I moved this from being a list to being a CollectionVGrid. I need to try this out on a non-emulator since I might have lost the swipe to delete on the CollectionVGrid? If so, I can always revert this back to being a list.

@LePips
Copy link
Member

LePips commented Oct 21, 2024

Sadly, we can't use swipeActions with CollectionVGrid. You'll see what will be used after I'm done with my work.

@JPKribs
Copy link
Member Author

JPKribs commented Oct 21, 2024

Sadly, we can't use swipeActions with CollectionVGrid. You'll see what will be used after I'm done with my work.

Shoot. Stylistically, I definitely preferred the CollectionVGrid.

I can turn this back into a list. On the list, I'm just am not a huge fan that the access token is too long to fit on most of the phones with the additional padding created by the list.

I could do something with the detail page where the token isn't on the list, but, that would mean, removing the current functionality where it copies, the token to the clipboard when selected.

Frankly, I could go either way. My UX/UI intuition is pretty meh so I might have to lean on your insight for which is better?

Shared/ViewModels/APIKeyViewModel.swift Outdated Show resolved Hide resolved
Shared/ViewModels/APIKeyViewModel.swift Outdated Show resolved Hide resolved
Shared/ViewModels/APIKeyViewModel.swift Outdated Show resolved Hide resolved
Shared/ViewModels/APIKeyViewModel.swift Outdated Show resolved Hide resolved
Shared/ViewModels/APIKeyViewModel.swift Outdated Show resolved Hide resolved
Shared/ViewModels/APIKeyViewModel.swift Outdated Show resolved Hide resolved
@LePips LePips merged commit 56fa032 into jellyfin:main Oct 25, 2024
4 checks passed
@JPKribs JPKribs deleted the adminDashboardAPIs branch November 12, 2024 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants