Add audio, subtitle, playback select for tvOS

[tonyd33]

Purpose

• Audio/subtitle/playback selection was completely missing in tvOS
• Opening up the audio/subtitle/playback selection menu opened to a button that said "None"
• Toggling autoplay reset focus

Changes

• Add audio, subtitle, and playback selection in tvOS
• Move playbackSpeed property into VideoPlayerManager to keep consistency with audio and subtitle property
• Make unselected label have unfilled circle icon, make selected label have checkmark circle filled icon

Testing

• Check audio, subtitle and playback select work in tvOS
• Tested both iOS and tvOS to make sure the playbackSpeed move didn't break anything
• Removed chapter select from the enum in SmallMenuOverlay because chapter selection already exists outside of that menu

Before	After
track select before	track select after

iOS playback speed works

Notes

While working on the fix, I noticed:

• Audio/subtitle were not set when loading video on tvOS in VideoPlayerManager, so opening the selection menu shows that no audio/subtitle track is selected until manual selection
• Opening the SmallMenuOverlay for the first time makes the default Text("None") button because lastFocusedSection is not set by default — fixed in this PR now

Do we want these problems fixed in this PR?

TODO

• Attach before and after images
• (Maybe) change playbackSpeed in VideoPlayerManager to Float in case we ever want to apply a nonstandard speed — lmk if we want this.
• (Maybe) refactor out shared code among the selection menus in SmallMenuOverlay — lmk if we want this

[LePips]

Thank you for working on this. The playback speed being pulled into the manager is great as it is related to #711, but I haven't made a good mechanism for having values "transfer" between different media items.

I see that the small overlay was expanded to fill the entire screen, which we don't want, but I'm fine with for now to fix later. I'm fine with the circles on the buttons, but I may change that later on.

Per the "lmk if we want this" comments:

1 - keep the playbackSpeed as the PlaybackSpeed type
2 - I'm always for some cleanliness, so I'm welcome to that.

In fact, I think that the entire overlay on tvOS needs a redesign, both in terms of design itself and implementation. I've just had to deal with SwiftUI and its lack of support on tvOS and I don't think it's the prettiest thing in the world. /rant

[tonyd33]

Thank you for working on this. The playback speed being pulled into the manager is great as it is related to #711, but I haven't made a good mechanism for having values "transfer" between different media items.

I see that the small overlay was expanded to fill the entire screen, which we don't want, but I'm fine with for now to fix later. I'm fine with the circles on the buttons, but I may change that later on.

Per the "lmk if we want this" comments:

1 - keep the playbackSpeed as the PlaybackSpeed type 2 - I'm always for some cleanliness, so I'm welcome to that.

In fact, I think that the entire overlay on tvOS needs a redesign, both in terms of design itself and implementation. I've just had to deal with SwiftUI and its lack of support on tvOS and I don't think it's the prettiest thing in the world. /rant

Just noticed the "Small" in "SmallMenuOverlay", haha.

For the circles on the buttons, I added it because changing from Text (no checkmark/image) to Label caused weird issues with the button width, making the text clip out of the button's bounds. Of course, these changes are likely going to be placeholders until the tvOS overlay overhaul.

Seeing as the playback slider is completely broken on tvOS among the other design issues, I'd be happy to see a rework on tvOS and help implement it. If you have mocks or even a detailed enough description of design goals, I'd love to incrementally work on it over the next while. We can discuss more on element

[lavavex]

This menu seems to have broken in tvos 17 and later, still works fine when run in tvos 15.4 simulator

[tonyd33]

This menu seems to have broken in tvos 17 and later, still works fine when run in tvos 15.4 simulator

Yeah, it seems like tvOS 17+ broke the whole overlay menu stuff in general, even before this commit. I'll see if there are any bandages I can come up with quickly, but we had been discussing revamping the overlay anyhow so this might get pushed until then

Edit: Ok so it turns out this line was the culprit. For some unholy reason, before tvOS 17, currentOverlayType = .main was run before currentOverlayType = .smallMenu in BarActionButtons and then the orders were reversed after tvOS 17. Removing that line fixes it.