Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor getDeviceName() for readability #6319

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CONTRIBUTORS.md
Original file line number Diff line number Diff line change
Expand Up @@ -93,6 +93,7 @@
- [Connor Smith](https://github.com/ConnorS1110)
- [iFraan](https://github.com/iFraan)
- [Ali](https://github.com/bu3alwa)
- [K. Kyle Puchkov](https://github.com/kepper104)

## Emby Contributors

Expand Down
63 changes: 31 additions & 32 deletions src/components/apphost.js
Original file line number Diff line number Diff line change
Expand Up @@ -132,42 +132,41 @@
}

function getDeviceName() {
if (!deviceName) {
if (browser.tizen) {
deviceName = 'Samsung Smart TV';
} else if (browser.web0s) {
deviceName = 'LG Smart TV';
} else if (browser.operaTv) {
deviceName = 'Opera TV';
} else if (browser.xboxOne) {
deviceName = 'Xbox One';
} else if (browser.ps4) {
deviceName = 'Sony PS4';
} else if (browser.chrome) {
deviceName = 'Chrome';
} else if (browser.edgeChromium) {
deviceName = 'Edge Chromium';
} else if (browser.edge) {
deviceName = 'Edge';
} else if (browser.firefox) {
deviceName = 'Firefox';
} else if (browser.opera) {
deviceName = 'Opera';
} else if (browser.safari) {
deviceName = 'Safari';
} else {
deviceName = 'Web Browser';
}
if (deviceName) {
return deviceName;
}

Check failure on line 138 in src/components/apphost.js

View workflow job for this annotation

GitHub Actions / Quality checks 👌🧪 / Run lint 🕵️‍♂️

Trailing spaces not allowed
kepper104 marked this conversation as resolved.
Show resolved Hide resolved
const deviceMappings = {
kepper104 marked this conversation as resolved.
Show resolved Hide resolved
tizen: 'Samsung Smart TV',
web0s: 'LG Smart TV',
operaTv: 'Opera TV',
xboxOne: 'Xbox One',
ps4: 'Sony PS4',
chrome: 'Chrome',
edgeChromium: 'Edge Chromium',
edge: 'Edge',
firefox: 'Firefox',
opera: 'Opera',
safari: 'Safari',

Check failure on line 150 in src/components/apphost.js

View workflow job for this annotation

GitHub Actions / Quality checks 👌🧪 / Run lint 🕵️‍♂️

Unexpected trailing comma
};
kepper104 marked this conversation as resolved.
Show resolved Hide resolved

deviceName = 'Web Browser'; // Default device name

if (browser.ipad) {
deviceName += ' iPad';
} else if (browser.iphone) {
deviceName += ' iPhone';
} else if (browser.android) {
deviceName += ' Android';
for (const key in deviceMappings) {
if (browser[key]) {
deviceName = deviceMappings[key];
break;
}
}

if (browser.ipad) {
deviceName += ' iPad';
} else if (browser.iphone) {
deviceName += ' iPhone';
} else if (browser.android) {
deviceName += ' Android';
}

Check failure on line 169 in src/components/apphost.js

View workflow job for this annotation

GitHub Actions / Quality checks 👌🧪 / Run lint 🕵️‍♂️

Trailing spaces not allowed
kepper104 marked this conversation as resolved.
Show resolved Hide resolved
return deviceName;
}

Expand Down
Loading