Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix lyric fetcher order not changeable in library options #6329

Merged
merged 1 commit into from
Nov 20, 2024
Merged

Fix lyric fetcher order not changeable in library options #6329

merged 1 commit into from
Nov 20, 2024

Conversation

nielsvanvelzen
Copy link
Member

Changes

  • Fix changing lyric fetcher order not changeable in library options (event listener was missing)
  • Fix help text about lyrics

Issues

@nielsvanvelzen nielsvanvelzen added the stable backport Backport into the next stable release label Nov 19, 2024
@nielsvanvelzen nielsvanvelzen requested a review from a team as a code owner November 19, 2024 21:25
@jellyfin-bot
Copy link
Collaborator

jellyfin-bot commented Nov 19, 2024 •
edited
Loading

Cloudflare Pages deployment

Latest commit e221872
Status ✅ Deployed!
Preview URL https://fe77fa11.jellyfin-web.pages.dev
Type 🔀 Preview

View build logs

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 19, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@nielsvanvelzen nielsvanvelzen mentioned this pull request Nov 19, 2024
Open
crobibero
crobibero approved these changes Nov 19, 2024
View reviewed changes
Copy link
Member

@crobibero crobibero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

disney-tarzan-tantor

@thornbill thornbill added this to the v10.10.4 milestone Nov 20, 2024
@thornbill thornbill added the bug Something isn't working label Nov 20, 2024
@thornbill thornbill merged commit 1496542 into jellyfin:release-10.10.z Nov 20, 2024
14 checks passed
@nielsvanvelzen nielsvanvelzen deleted the fix-lyric-sort branch November 20, 2024 06:39
@nielsvanvelzen nielsvanvelzen changed the title Fix changing lyric fetcher order not changeable in library options Fix lyric fetcher order not changeable in library options Nov 20, 2024
@jellyfin-bot jellyfin-bot removed the stable backport Backport into the next stable release label Nov 30, 2024
joshuaboniface pushed a commit that referenced this pull request Nov 30, 2024
@nielsvanvelzen @joshuaboniface
Backport pull request #6329 from jellyfin-web/release-10.10.z
a530389 
Fix lyric fetcher order not changeable in library options

Original-merge: 1496542

Merged-by: thornbill <thornbill@users.noreply.github.com>

Backported-by: Joshua M. Boniface <joshua@boniface.me>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crobibero crobibero crobibero approved these changes

@thornbill thornbill thornbill approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
Jellyfin 10.10
Status: Done
Milestone
v10.10.4
Development

Successfully merging this pull request may close these issues.
4 participants
@nielsvanvelzen @jellyfin-bot @thornbill @crobibero