From 3b976894ebeffecea70c564d29d8ba3adc639645 Mon Sep 17 00:00:00 2001 From: Liam Newman Date: Tue, 14 Feb 2017 08:24:32 -0800 Subject: [PATCH] Updated based on feedback from @daniel-beck --- .../2017/2017-02-14-declarative-notifications.adoc | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/content/blog/2017/2017-02-14-declarative-notifications.adoc b/content/blog/2017/2017-02-14-declarative-notifications.adoc index 1eab6b9e295f..2c1ed74f18ec 100644 --- a/content/blog/2017/2017-02-14-declarative-notifications.adoc +++ b/content/blog/2017/2017-02-14-declarative-notifications.adoc @@ -30,14 +30,14 @@ sending notifications. In this blog post, we'll pull in the notification method we created for link:/blog/2016/07/18/pipline-notifications/[Sending Notifications in Pipeline]. -We'll show how the structure of Then we'll move that notification sending method into shared library, letting -use call it from other projects and keeping our `Jenkinsfile` concise and +us call it from other projects and keeping our `Jenkinsfile` concise and understandable. == Setup -The setup for this post is a continuation of the previous. +The setup for this post is a almost the same as the +link:/blog/2017/02/10/declarative-html-publisher/[previous post]. I've used a new branch link:https://github.com/bitwiseman/hermann[my same fork] of the link:https://github.com/reiseburo/hermann[hermann project]: @@ -47,7 +47,7 @@ the same as did it previous post. Also the same as before, I've set this Pipeline's Git configuration to automatically "Clean after checkout". -In addition, I still have my targets setup from the +In addition, I still have my notification targets setup from the "link:/blog/2016/07/18/pipline-notifications/[Sending Notifications in Pipeline]" blog post. Take a look there for help setting up the plugin:slack[Slack], @@ -156,15 +156,15 @@ def sendNotifications(String buildStatus = 'STARTED') { } ---- -.Declarative is still Jenkins Pipeline +.Declarative is still Jenkins Pipeline **** Jenkins Declarative Pipeline is still *Jenkins*, still *Pipeline*, and still *Groovy*. Declarative Pipeline - everything inside -the `pipeline {}` block - is a domain-specific subset is Groovy, but outside that +the `pipeline {}` block - is a domain-specific subset of Groovy, but outside that we can still access all the facilities of Java, Groovy, and Scripted Pipeline. Looking at the method definition above, some of you will be saying, -"Wait minute, wasn't Declarative Pipeline was supposed to get me away from +"Wait a minute, wasn't Declarative Pipeline supposed to get me away from Groovy, function definitions, and conditional logic?" When I first saw this, that's certainly what I said, only with a few more expletives.