Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changelog and upgrade guide for 2.332.1 #4960

Merged
merged 6 commits into from
Mar 9, 2022
Merged

Changelog and upgrade guide for 2.332.1 #4960

merged 6 commits into from
Mar 9, 2022

Conversation

MarkEWaite
Copy link
Contributor

@MarkEWaite MarkEWaite commented Mar 3, 2022 •
edited
Loading

Changelog and upgrade guide for 2.332.1

Changes from 2.319.3 selected by me. Open to recommendations.

changelog

Upgrade Guide 2.332.1

upgrade-guide

@MarkEWaite
Changelog and upgrade guide for 2.332.1
f867424 
Changes from 2.319.3 selected by me.  Open to recommendations.
@MarkEWaite MarkEWaite requested a review from a team as a code owner March 3, 2022 23:18
@probot-autolabeler probot-autolabeler bot added the changelog Jenkins changelogs label Mar 3, 2022
kwhetstone
kwhetstone reviewed Mar 8, 2022
View reviewed changes
Copy link
Contributor

@kwhetstone kwhetstone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally this looks great, and I'm ok with the changes here

content/_data/changelogs/lts.yml Outdated Show resolved Hide resolved
@MarkEWaite @kwhetstone
Improve changelog phrasing
aae391a 
Thanks to @kwhetstone

Co-authored-by: Kristin Whetstone <kwhetstone@cloudbees.com>
@MarkEWaite MarkEWaite merged commit 779a914 into jenkins-infra:master Mar 9, 2022
@MarkEWaite MarkEWaite deleted the changelog-2.332.1 branch March 9, 2022 14:10
@daniel-beck
Copy link
Contributor

jenkinsci/jenkins#6111 (comment) is feedback on the upgrade guide being incomplete. The PR has upgrade guide content, and is labeled upgrade-guide-needed. Are we not basing the content for this on that label?

@MarkEWaite
Copy link
Contributor Author

MarkEWaite commented Mar 21, 2022 •
edited
Loading

jenkinsci/jenkins#6111 (comment) is feedback on the upgrade guide being incomplete. The PR has upgrade guide content, and is labeled upgrade-guide-needed. Are we not basing the content for this on that label?

Thanks for asking the question @daniel-beck .

It appears that a Jenkins core pull request with the label removed is not currently included in the automatically generated changelog for weekly. The LTS changelog content was assembled from my interactive review of weekly changelog entries. I missed the entry both for the changelog and for the upgrade guide.

I've submitted a pull request to the changelog generator so that it will include the removed label.

I'll review the pull requests with the removed labels and include them in the appropriate weekly changelogs, LTS changelogs, and upgrade guides.

It may be a few days before I can complete those corrections.

I failed to check the upgrade-guide-needed label that would have detected it as well because I had already reviewed the text of the selected changelog entries for "upgrade guide" entries. I'll use that label for future upgrade guide content searches.

MarkEWaite added a commit to MarkEWaite/jenkins-core-changelog-generator that referenced this pull request Mar 21, 2022
@MarkEWaite
Include removed label in the changelog
6236373 
Pull requests to Jenkins core that were labeled with `remove` were not
included in the automated weekly changelogs for Jenkins 2.339 and earlier.
Let's include them in the changelog.

jenkins-infra/jenkins.io#4960 (comment)
raises the question in response to the question asking why the JNDI
removal was not included in the 2.332.1 upgrade guide.
This was referenced Mar 21, 2022
Merged
Merged
MarkEWaite added a commit to MarkEWaite/jenkins.io that referenced this pull request Mar 23, 2022
@MarkEWaite
Include core PR jenkins-infra#6111 in changelog and upgrade guide
e8a517d 
jenkins-infra#4960 (comment) detected the problem
MarkEWaite added a commit that referenced this pull request Mar 23, 2022
@MarkEWaite
Include remove label in changelogs (#5017)
b91770a 
* Include core PR #6111 in changelog and upgrade guide

#4960 (comment) detected the problem

* Add 2.333 changelog entry for JRuby removal

* Add JNR removal to 2.338 changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kwhetstone kwhetstone kwhetstone left review comments

@timja timja timja approved these changes

Assignees
No one assigned
Labels
changelog Jenkins changelogs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@MarkEWaite @daniel-beck @kwhetstone @timja