Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Outside package #56

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Outside package #56

wants to merge 6 commits into from

Conversation

Bresiu
Copy link

@Bresiu Bresiu commented Sep 4, 2015

No description provided.

@orrc
Copy link
Member

orrc commented Sep 4, 2015

Sounds good, but please resubmit without all the formatting changes.

Sorry I can't review the code just now; I'll check it out when I get a chance next week.

@jenkinsadmin
Copy link
Member

Thank you for a pull request! Please check this document for how the Jenkins project handles pull requests

@koral--
Copy link

koral-- commented Sep 6, 2015

I reverted formatting changes but there are few issues to consider.

  1. Not only crashes but also ANRs originating outside tested package should be ignored.
  2. Differentiating between tested and "outside" package should be performed for each series separately. Now eg. if monkey output contains log from testing packages A and B, if test of package A has completed without issues and package B crashed during its own test then result will be falsely equal to success.
  3. Consider case when launcher app (outside one) crashes after injecting 3 of 1000 events to tested app. With current code it will be treated as success which does not sound good. One of the solutions may be:
  • add all --ignore-* options to monkey command line, so it won't stop when it detects crash or ANR (it may come outside a tested package)
  • if counters of finishes and injected events matches their expected values then scan each series for crashes and ANR ignoring ones coming from outside a tested package

@orrc orrc self-assigned this Nov 14, 2017
@Bresiu
Copy link
Author

Bresiu commented Feb 15, 2019

What is happening with this PR? Should we merge / close it?

@orrc orrc removed their assignment Sep 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants