Skip to content

Commit cbf183c

Browse files
committed
[SECURITY-2351]
1 parent d1d7756 commit cbf183c

File tree

1 file changed

+6
-0
lines changed

1 file changed

+6
-0
lines changed

Diff for: src/main/java/com/cloudbees/jenkins/plugins/awscredentials/AWSCredentialsImpl.java

+6
Original file line numberDiff line numberDiff line change
@@ -56,6 +56,7 @@
5656
import org.kohsuke.stapler.DataBoundConstructor;
5757
import org.kohsuke.stapler.DataBoundSetter;
5858
import org.kohsuke.stapler.QueryParameter;
59+
import org.kohsuke.stapler.verb.POST;
5960

6061
import java.net.HttpURLConnection;
6162
import java.util.logging.Level;
@@ -280,13 +281,18 @@ public String getDisplayName() {
280281

281282
public static final Integer DEFAULT_STS_TOKEN_DURATION = STS_CREDENTIALS_DURATION_SECONDS;
282283

284+
@POST
283285
public FormValidation doCheckSecretKey(@QueryParameter("accessKey") final String accessKey,
284286
@QueryParameter("iamRoleArn") final String iamRoleArn,
285287
@QueryParameter("iamExternalId") final String iamExternalId,
286288
@QueryParameter("iamMfaSerialNumber") final String iamMfaSerialNumber,
287289
@QueryParameter("iamMfaToken") final String iamMfaToken,
288290
@QueryParameter("stsTokenDuration") final Integer stsTokenDuration,
289291
@QueryParameter final String secretKey) {
292+
if (!Jenkins.get().hasPermission(Jenkins.ADMINISTER)) {
293+
// for security reasons, do not perform any check if the user is not an admin
294+
return FormValidation.ok();
295+
}
290296
if (StringUtils.isBlank(accessKey) && StringUtils.isBlank(secretKey)) {
291297
return FormValidation.ok();
292298
}

0 commit comments

Comments
 (0)