From 6c5ad5d0215577889ba53f2db6155da44dd0dc8b Mon Sep 17 00:00:00 2001 From: Mark Waite Date: Sat, 4 May 2024 07:29:23 -0600 Subject: [PATCH] Remove unused commons-validator dependency The commons-validator dependency was added in the 1.9.1 release as part of 468a59527a9b906f1790486674b3b6475bf2f4a3, though there seems to have been no references to validator classes in any history of the repository. It was not includeed in the 1.9 release or any prior releases. The commons-validator dependency was added to the master branch after the 1.9.1 release as part of 5ca8ab7a3b839c8db1af9ba485754eb81fd6a1e8. There are no references to validator classes in the current source code. Removing commons-validator reduces the plugin from over 1MB to less than 60KB. Comparisons are listed below: -rw-rw-r--. 1 mwaite mwaite 54015 Oct 25 2021 ../badge-1.9.hpi -rw-rw-r--. 1 mwaite mwaite 1135545 Jan 12 2022 ../badge-1.9.1.hpi -rw-rw-r--. 1 mwaite mwaite 56150 May 4 07:35 target/badge.hpi --- .github/dependabot.yml | 2 -- pom.xml | 5 ----- 2 files changed, 7 deletions(-) diff --git a/.github/dependabot.yml b/.github/dependabot.yml index dea42ab..144a580 100644 --- a/.github/dependabot.yml +++ b/.github/dependabot.yml @@ -8,5 +8,3 @@ updates: - "dependencies" schedule: interval: "monthly" - ignore: - - dependency-name: "commons-validator:commons-validator" diff --git a/pom.xml b/pom.xml index 60611d7..cfc2136 100644 --- a/pom.xml +++ b/pom.xml @@ -111,11 +111,6 @@ org.jenkins-ci.plugins.workflow workflow-step-api - - commons-validator - commons-validator - 1.5.1 - org.jenkins-ci.plugins