Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ootb webhooks support #58

Merged
merged 3 commits into from
Aug 27, 2019
Merged

Conversation

chpro
Copy link
Contributor

@chpro chpro commented Jun 13, 2018

An implementation to support the webhooks which come with bitbucket server ootb. No plugin needs to be installed.

See atlassian documentation for more information about webhooks and their payload.

https://confluence.atlassian.com/bitbucketserver0510/managing-webhooks-in-bitbucket-server-951390737.html
https://confluence.atlassian.com/bitbucketserver0510/event-payload-951390742.html

}

String user = payload.getJSONObject("actor").getString("name");
String url = repo.getJSONObject("project").getString("key").toLowerCase() + "/" + repo.getString("name");

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does not work on my site. I needed to replace repo.getString("name") with repo.getString("slug") to make it work. The name part is not equal to the slug part, if there is a whitespace in the name.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you will incorporate the changes

Copy link

@dhufnagel dhufnagel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works on our Jenkins Server with version 2.121.1 and self hosted Bitbucket with built-in webhook

@HerrmannHinz
Copy link

any update on this?

Copy link

@krotte1 krotte1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes look great. Lets get them merged up so another release can be created. @jenkinsci/code-reviewers

@krotte1
Copy link

krotte1 commented Feb 6, 2019

When is this pull-request going to be merged and a new build created? The fixes on this pull-request are desperately needed for anyone using an on-prem version of Bitbucket.

@krotte1
Copy link

krotte1 commented Apr 10, 2019

How do we get jenkinsci to pay attention to this plugin. There are valid pull requests out there that need to be merged, but nobody is doing it!! This is extremely frustrating.

@thismatters
Copy link

@krotte1 you're right, this is frustrating. I would love to see this change incorporated since I have no control over what plugins are installed on our Bitbucket Server.

@krotte1
Copy link

krotte1 commented Aug 14, 2019

@fbelzunc I noticed that you have been maintaining this repo through other recent pull request merges... I was wondering if you could review this pull request and get it merged... or give me the permission to do so?

@krotte1
Copy link

krotte1 commented Aug 15, 2019

@fbelzunc I and the rest of the on-prem bitbucket/Jenkins users would really love to have this fix merged in. Because of the differences in payload sent by server vs cloud, this plugin is essentially useless without this fix.

@krotte1
Copy link

krotte1 commented Aug 17, 2019

@fbelzunc @arcadien @nremond @ndeloof I was really hoping that we could get this pull request merged. Can one of you please do that? It expands support to botbucket server on prem users.

@fbelzunc
Copy link
Contributor

I will check this next week.

@krotte1
Copy link

krotte1 commented Aug 27, 2019

@fbelzunc we’re you able to check this out?

@fbelzunc fbelzunc merged commit 2b9fe5e into jenkinsci:master Aug 27, 2019
@krotte1
Copy link

krotte1 commented Aug 30, 2019

Thank you @fbelzunc for getting this merged!!!!

tzachs pushed a commit that referenced this pull request Jul 29, 2020
* Added possibility to process trigger from bitbucket server default webhooks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants