-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ootb webhooks support #58
Conversation
} | ||
|
||
String user = payload.getJSONObject("actor").getString("name"); | ||
String url = repo.getJSONObject("project").getString("key").toLowerCase() + "/" + repo.getString("name"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This does not work on my site. I needed to replace repo.getString("name")
with repo.getString("slug")
to make it work. The name part is not equal to the slug part, if there is a whitespace in the name.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you will incorporate the changes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works on our Jenkins Server with version 2.121.1 and self hosted Bitbucket with built-in webhook
any update on this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These changes look great. Lets get them merged up so another release can be created. @jenkinsci/code-reviewers
When is this pull-request going to be merged and a new build created? The fixes on this pull-request are desperately needed for anyone using an on-prem version of Bitbucket. |
How do we get jenkinsci to pay attention to this plugin. There are valid pull requests out there that need to be merged, but nobody is doing it!! This is extremely frustrating. |
@krotte1 you're right, this is frustrating. I would love to see this change incorporated since I have no control over what plugins are installed on our Bitbucket Server. |
@fbelzunc I noticed that you have been maintaining this repo through other recent pull request merges... I was wondering if you could review this pull request and get it merged... or give me the permission to do so? |
@fbelzunc I and the rest of the on-prem bitbucket/Jenkins users would really love to have this fix merged in. Because of the differences in payload sent by server vs cloud, this plugin is essentially useless without this fix. |
I will check this next week. |
@fbelzunc we’re you able to check this out? |
Thank you @fbelzunc for getting this merged!!!! |
* Added possibility to process trigger from bitbucket server default webhooks
An implementation to support the webhooks which come with bitbucket server ootb. No plugin needs to be installed.
See atlassian documentation for more information about webhooks and their payload.
https://confluence.atlassian.com/bitbucketserver0510/managing-webhooks-in-bitbucket-server-951390737.html
https://confluence.atlassian.com/bitbucketserver0510/event-payload-951390742.html