Update UI to use new Jenkins Design Library #171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 19, 2022 21:19
The original claim icon is now replaced by the built in Jenkins Design Library user icon. Build Resuly icons are now rendered using the same flow as in the jenkinsci/jenkins repository.
The images in the README have now been updated to show the new UI styles from the Jenkins Design Library.
|
Thanks for this work on the UI. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The claims plugin was using older table formatting and the original Jenkins styles. This pull request includes changes to UI styles using elements from the Jenkins Design Library.
This is my first time making UI changes to a Jenkins plugin so happy to recieve any feedback you have.
Screenshots of the new UI have been provided in the docs folder. The major changes are to the way the correct build result icon is retrieved, and a margin was added to the badge to create space between test names and the claim badge. This was tested against Jenkins 2.361.1