Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade HtmlUnit from 2.x to 3.x #237

Merged
merged 4 commits into from
Jun 5, 2023

Conversation

timja-bot
Copy link
Contributor

This is an autogenerated PR for updating HtmlUnit

It follows the migration guide

Ping @timja if any questions

script source

@timja-bot timja-bot added the dependencies Pull requests that update a dependency file label Jun 4, 2023
@Greybird
Copy link
Contributor

Greybird commented Jun 5, 2023

Hi @timja ; just for reference, a code update to HtmlOption.getValueAttribute was made incorrectly by the bot. Just to let you know should you think the bot could be improved.

@Greybird Greybird merged commit e473ab3 into jenkinsci:master Jun 5, 2023
@timja
Copy link
Member

timja commented Jun 5, 2023

Hi @timja ; just for reference, a code update to HtmlOption.getValueAttribute was made incorrectly by the bot. Just to let you know should you think the bot could be improved.

Aware that's the only thing that I know of that isn't handled by the bot so far.
It uses a find and replace rather than an AST aware migration.

The rule is to migrate getValueAttribute except when the class is an HtmlOption, but can't handle that with a simple find and replace.

It doesn't affect many cases so either I or maintainers will fix that up. 😄

Thanks for sorting this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants