Skip to content
This repository has been archived by the owner on Jan 21, 2024. It is now read-only.

Adjusted jenkins-agent script for direct connection (+ FROM jenkins/slave:3.35-3) #118

Merged
merged 2 commits into from
Sep 27, 2019
Merged

Conversation

alxsap
Copy link
Contributor

@alxsap alxsap commented Sep 24, 2019

Remoting#3.34 introduced direct inbound TCP agent connections (to masters without Web UI/HTTP port). The feature is documented here.

This Pull Request adds the required parameters to the jenkins-agent script. In particular this change is needed to enable the Kubernetes plugin to make use of this feature, e.g. in combination with Jenkinsfile Runner on Kubernetes (without HTTP port).

@oleg-nenashev
Copy link
Member

@alxsap alxsap changed the title WIP: Adjusted jenkins-agent script for direct connection Adjusted jenkins-agent script for direct connection Sep 27, 2019
@alxsap
Copy link
Contributor Author

alxsap commented Sep 27, 2019

Created https://github.com/jenkinsci/docker-slave/releases/tag/3.35-3 to unblock it

Thanks @oleg-nenashev. I updated the Dockerfiles. The Pull Request is ready for review and merge now, from my perspective.

@alxsap alxsap changed the title Adjusted jenkins-agent script for direct connection Adjusted jenkins-agent script for direct connection (+ FROM jenkins/slave:3.35-3) Sep 27, 2019
Copy link
Member

@oleg-nenashev oleg-nenashev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will enable Dependabot to avoid the manual steps, but it is good for now. All production images are updated. I will cut a release to deliver it

@oleg-nenashev oleg-nenashev merged commit c383642 into jenkinsci:master Sep 27, 2019
lemeurherve pushed a commit to lemeurherve/jenkinsci-docker-inbound-agent that referenced this pull request Nov 19, 2023
lemeurherve pushed a commit to lemeurherve/docker-agent that referenced this pull request Nov 28, 2023
…xsap/PR_directConnect

Adjusted jenkins-agent script for direct connection (+ FROM jenkins/slave:3.35-3)
lemeurherve pushed a commit to lemeurherve/docker-agent that referenced this pull request Nov 28, 2023
…xsap/PR_directConnect

Adjusted jenkins-agent script for direct connection (+ FROM jenkins/slave:3.35-3)
lemeurherve pushed a commit to lemeurherve/docker-agent that referenced this pull request Nov 28, 2023
…xsap/PR_directConnect

Adjusted jenkins-agent script for direct connection (+ FROM jenkins/slave:3.35-3)
lemeurherve pushed a commit to lemeurherve/docker-agent that referenced this pull request Nov 28, 2023
…xsap/PR_directConnect

Adjusted jenkins-agent script for direct connection (+ FROM jenkins/slave:3.35-3)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants