This repository has been archived by the owner on Jan 21, 2024. It is now read-only.
fixup: correct tags and publication for Windows images #374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dduportal
reviewed
Jul 30, 2023
lemeurherve
changed the title
This was referenced Jul 31, 2023
lemeurherve
added a commit
that referenced
this pull request
Jul 31, 2023
lemeurherve
pushed a commit
to lemeurherve/jenkinsci-docker-inbound-agent
that referenced
this pull request
Nov 19, 2023
…in /17/bullseye (jenkinsci#374) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
lemeurherve
pushed a commit
to lemeurherve/docker-agent
that referenced
this pull request
Jan 12, 2024
…e/fix-tag-and-publish fixup: correct tags and publication for Windows images
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a fixup of #363:
JAVA_MAJOR_VERSIONenvironment variable (it was always the one specified in Windows Dockerfiles,17): 6b44cc4OutputJAVA_MAJOR_VERSIONenvironment variable in tests logs (Quality of Life): 3fe2ee5Extracted in chore: show
JAVA_MAJOR_VERSIONin tests output #376Correct tags without any additional build number in it: 889f075See fixup: correct tags and publication for Windows images #374 (comment)
Cleanup unusedBuildNumber(while used in docker-agent, not applicable here) andPushVersions(there is no call without it) and fix publication: 5d4f4a2See fixup: correct tags and publication for Windows images #374 (comment)
Testing done
https://ci.jenkins.io/job/Packaging/job/docker-inbound-agent/job/PR-374/2/
Submitter checklist