Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

usage of org-list may incur github rate limit #831

Open
maorfr opened this issue Feb 13, 2022 · 0 comments
Open

usage of org-list may incur github rate limit #831

maorfr opened this issue Feb 13, 2022 · 0 comments

Comments

@maorfr
Copy link
Member

maorfr commented Feb 13, 2022

when using the org-list feature of the plugin, each PR author will be checked if they are members of the organizations in that list.
given that jenkins is defined as an authenticated user, the returned status will be 404 (according to https://docs.github.com/en/rest/reference/orgs#check-organization-membership-for-a-user)

this poses a problem related to github rate limit.

assuming a user like dependabot creates a lot of PRs, and for each PR we check if the user is a member of an org on the list - we will exhaust the rate limit.

even when using the conditional requests feature (for reference, we make ~100k requests to the github api per hour), this will still cause us to hit rate limit, as only a 304 return status will not count against the rate limit.

essentially this causes organizations with multiple repos to be "attacked" by simply having too many open PRs from dependabot 😄

internal reference: https://issues.redhat.com/browse/APPSRE-4423

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant