Skip comments on closed PR #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 Can't wait for this... current behavior is driving my team and I bonkers 😄 |
DavidTanner
added a commit
that referenced
this pull request
Sep 26, 2014
Skip comments on closed PR
nosmo
pushed a commit
to nosmo/ghprb-plugin
that referenced
this pull request
Dec 12, 2018
Skip comments on closed PR
JackPGreen
added a commit
to JackPGreen/ghprb-plugin
that referenced
this pull request
Aug 19, 2024
Skips all kind of event triggers for closed PRs, rather than just for comments as per jenkinsci#54. Fixes: jenkinsci#865
JackPGreen
added a commit
to JackPGreen/jenkinsci-plugin-ghprb
that referenced
this pull request
Aug 19, 2024
Skips all kind of event triggers for closed PRs, rather than just for comments as per jenkinsci/ghprb-plugin#54. Fixes: jenkinsci/ghprb-plugin#865
3 tasks
kwart
pushed a commit
to hazelcast/jenkinsci-plugin-ghprb
that referenced
this pull request
Sep 4, 2024
Skips all kind of event triggers for closed PRs, rather than just for comments as per jenkinsci/ghprb-plugin#54. I've not added a test to cover this, as there's no existing test coverage for `pull_request` events in `org.jenkinsci.plugins.ghprb.GhprbRootActionTest`, nor is there any example payloads in `org.jenkinsci.plugins.ghprb.GhprbTestUtil`. Fixes: jenkinsci/ghprb-plugin#865, [DI-248](https://hazelcast.atlassian.net/browse/DI-248) Post-merge actions: - [ ] Deploy in Jenkins - [ ] Test - [ ] Raise upstream PR [DI-248]: https://hazelcast.atlassian.net/browse/DI-248?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ
JackPGreen
added a commit
to JackPGreen/ghprb-plugin
that referenced
this pull request
Sep 5, 2024
Skips all kind of event triggers for closed PRs, rather than just for comments as per jenkinsci#54. I've not added a test to cover this, as there's no existing test coverage for `pull_request` events in `org.jenkinsci.plugins.ghprb.GhprbRootActionTest`, nor is there any example payloads in `org.jenkinsci.plugins.ghprb.GhprbTestUtil`. Fixes: jenkinsci#865
This was referenced Sep 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Job triggering by comment on closed PR seems odd. This PR fix it.