Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extended revision matching does not work w/explicit revision #s #4

Open
noise opened this issue Apr 26, 2012 · 2 comments
Open

Extended revision matching does not work w/explicit revision #s #4

noise opened this issue Apr 26, 2012 · 2 comments

Comments

@noise
Copy link

noise commented Apr 26, 2012

First, some details:

  • Jenkins 1.452
  • Ivy Plugin 1.21
  • "Use extended revision matching to filter the project dependency graph" enabled
  • Freestyle project

Dependee/lib project's ivy info:

  <info organisation="com.example" module="my-svc" status="integration" branch="trunk" revision="1.0.1" />

Depender/app dep:

  <dependency org="com.example" name="my-svc" branch="trunk" rev="1.0.1" />

As such it fails to be recognized as a dependency by the plugin. If I change it to either:

  <dependency org="com.example" name="my-svc" branch="trunk" rev="1.0.+" />
  <dependency org="com.example" name="my-svc" branch="trunk" rev="latest.integration" />

Then it works as expected. Why won't the explicit version work?

@noise
Copy link
Author

noise commented Apr 27, 2012

I debugged this and found the offending line at:
https://github.com/jenkinsci/ivy-plugin/blob/master/src/main/java/hudson/ivy/IvyBuildTrigger.java#L494
added in commit: af3db7f:

  captures = (matcher != null && matcher.isDynamic(depRevId));

It looks like prior to that there was an option to "enforceDynamicMatching" or not, but I don't get the rationale to deny version matches for explicit versioning. Can anyone elaborate on the logic here?

Thanks in advance!

noise pushed a commit to noise/ivy-plugin that referenced this issue May 1, 2012
@johnou
Copy link
Member

johnou commented Jul 17, 2013

@ndeloof would you have a minute to share your thoughts on this issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants