Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update more bundled plugins #7341

Merged
merged 1 commit into from
Nov 13, 2022
Merged

Update more bundled plugins #7341

merged 1 commit into from
Nov 13, 2022

Conversation

basil
Copy link
Member

@basil basil commented Nov 8, 2022

Our usual policy is not to update bundled plugins without a specific reason, such as a security fix. In this case the specific reason is the same as that of #7324 and #7175: to mitigate the impact of JENKINS-69361.

Testing done

Ran mvn clean verify -Dtest=jenkins.install.LoadDetachedPluginsTest,jenkins.model.StartupTest (including un-ignored LoadDetachedPluginsTest#noUpdateSiteWarnings) locally.

Proposed changelog entries

Update several bundled plugins to the latest versions.

Proposed upgrade guidelines

N/A

Submitter checklist

  • The Jira issue, if it exists, is well-described.
  • The changelog entries and upgrade guidelines are appropriate for the audience affected by the change (users or developers, depending on the change) and are in the imperative mood (see examples).
    • Fill in the Proposed upgrade guidelines section only if there are breaking changes or changes that may require extra steps from users during upgrade.
  • There is automated testing or an explanation as to why this change has no tests.
  • New public classes, fields, and methods are annotated with @Restricted or have @since TODO Javadocs, as appropriate.
  • New deprecations are annotated with @Deprecated(since = "TODO") or @Deprecated(forRemoval = true, since = "TODO"), if applicable.
  • New or substantially changed JavaScript is not defined inline and does not call eval to ease future introduction of Content Security Policy (CSP) directives (see documentation).
  • For dependency updates, there are links to external changelogs and, if possible, full differentials.
  • For new APIs and extension points, there is a link to at least one consumer.

Desired reviewers

@mention

Maintainer checklist

Before the changes are marked as ready-for-merge:

  • There are at least two (2) approvals for the pull request and no outstanding requests for change.
  • Conversations in the pull request are over, or it is explicit that a reviewer is not blocking the change.
  • Changelog entries in the pull request title and/or Proposed changelog entries are accurate, human-readable, and in the imperative mood.
  • Proper changelog labels are set so that the changelog can be generated automatically.
  • If the change needs additional upgrade steps from users, the upgrade-guide-needed label is set and there is a Proposed upgrade guidelines section in the pull request title (see example).
  • If it would make sense to backport the change to LTS, a Jira issue must exist, be a Bug or Improvement, and be labeled as lts-candidate to be considered (see query).

@basil basil added dependencies Pull requests that update a dependency file java Pull requests that update Java code labels Nov 8, 2022
@NotMyFault NotMyFault requested a review from a team November 10, 2022 09:33
<groupId>org.jenkins-ci.modules</groupId>
<artifactId>sshd</artifactId>
<version>3.236.ved5e1b_cb_50b_2</version>
<version>3.249.v2dc2ea_416e33</version>
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another benefit of this PR is that it pulls in jenkinsci/sshd-plugin#88, which consumes instance-identity as a plugin rather than a module. This is technically more correct, since this version of core does not deliver instance-identity as a module.

@basil
Copy link
Member Author

basil commented Nov 12, 2022

This PR is now ready for merge. We will merge it after approximately 24 hours if there is no negative feedback. Please see the merge process documentation for more information about the merge process. Thanks!

@basil basil self-assigned this Nov 12, 2022
@basil basil added the ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback label Nov 12, 2022
@basil basil merged commit 952d4f9 into jenkinsci:master Nov 13, 2022
@basil basil deleted the detached branch November 13, 2022 17:35
@MarkEWaite MarkEWaite added the skip-changelog Should not be shown in the changelog label Nov 15, 2022
@basil basil mentioned this pull request Jun 12, 2023
@basil basil mentioned this pull request Nov 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file java Pull requests that update Java code ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback skip-changelog Should not be shown in the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants