-
Notifications
You must be signed in to change notification settings - Fork 337
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
URL-encode links to tests #660
Conversation
@jenkinsci/core-security-review Any objection to this? I can't think of a reason why URL-encoding the test name would be harmful, but maybe I'm missing something here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks to everyone who contributed to fixing this bug. Links under 'All Tests' are now percent-encoded, but spaces are being replaced with + signs, which breaks the links. Manually replacing + with spaces or %20 makes them work again. Meanwhile, links under 'All Failed Tests' are still preserving square brackets ([]) as-is. NOTE: Previously, only square brackets were an issue, and spaces were preserved. |
see #659 (comment) |
As I understand it, there's nothing more that can be done regarding the last report, correct? Then we'll rely solely on the ' Thank you very much, though. |
As requested previously, please file a separate ticket for any other places where the URL is not properly encoded, ideally with a PR that resolves the issue. |
Fixes #659
Testing done
mvn clean verify
Submitter checklist