Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Include jobs/*/config.xml for backups #211

Closed
wants to merge 1 commit into from

Conversation

pawelprazak
Copy link

For easier workarounds for #104 and #210 specifically.

This is the minimal change, but a better one would be to include it only for Multi-branch jobs/projects.

For easier workarounds for #104 and #210 specifically
@tomaszsek tomaszsek changed the title Include jobs/*/config.xml for backups [WIP] Include jobs/*/config.xml for backups Nov 26, 2019
@tomaszsek
Copy link

We have to split backup:

  • create tar as we did before in temporary directory
  • loop over all jobs detects if it is multibranch and add the config.xml file to the tar(tar -uf filename.tar new_file)
  • run gzip which will create compressed file .tar.gz

Don't forget to create the e2e test https://github.com/jenkinsci/kubernetes-operator/tree/master/backup/pvc/e2e.

@pbecotte
Copy link

What is the status of this? Anything that someone could help with?

@tomaszsek
Copy link

Hi @pbecotte,

If you have spare time you can help us with this improvement. If don't please tell us and we will try the best to do it for you.

Cheers

@pbecotte
Copy link

Sure, but not sure what its waiting on. The items from your comment from Nov 26?

@tomaszsek
Copy link

Yes, feel free to create another PR and follow the instructions from this comment #211 (comment).

@tomaszsek tomaszsek closed this Jan 18, 2020
@tomaszsek tomaszsek deleted the backup.sh-patch-1 branch January 18, 2020 19:33
@pniederlag
Copy link

Just for the records: this has been fixed in v0.0.8 PVC backup provider. Thx!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants