backups should only exclude config.xml in top level job directories, … #251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ones below that are artifacts
|
@pbecotte I've improved e2e tests and added your fix to the |
|
Ack, forgot to respond! We have been running that since, with things working nicely. |
|
this fix completely breaks folders and org folders, and seems to prevent restoration of multibranch pipeline jobs from working at all for me |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ones below that are artifacts
#104 #210
Hopefully this fixes any issues with restore of multibranch/org folder jobs. Notice that I changed the base image for the backup job. The debian image IS much bigger. However, the busybox version of tar doesn't include any options for tweaking the way the exclusion patterns work. Up to you- can write a more complicated script to accomplish the same goal, but felt like keeping it to one line was worth the extra few MBs.