Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use a versionthat works give prior releases #149

Closed
wants to merge 1 commit into from

Conversation

jtnord
Copy link
Member

@jtnord jtnord commented Jan 13, 2022

400.v12312312 is older than 1.1 in Maven but not jenkins. this confuses tools that use maven for version comparison, most likely dependabot et al).

@jglick @Pldi23

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

`400.v12312312` is older than `1.1` in Maven but not jenkins.  this confuses tools that use maven for version comparison, most likely dependabot et al).
@@ -1,3 +1,3 @@
-Pconsume-incrementals
-Pmight-produce-incrementals
-Dchangelist.format=%d.v%s
-Dchangelist.format=%d-v%s
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@daniel-beck
Copy link
Member

dependabot

Dependabot seems to handle it well: jenkinsci/jenkins#6159

Copy link
Member

@jglick jglick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suspect just updating the extension to 1.3 should suffice.

@jtnord
Copy link
Member Author

jtnord commented Jan 13, 2022

dependabot

Dependabot seems to handle it well: jenkinsci/jenkins#6159

me goes off to file an issue against dependabot

@jtnord
Copy link
Member Author

jtnord commented Jan 13, 2022

I suspect just updating the extension to 1.3 should suffice.

how would that help? it will still produce versions like nnn.vxxxxxxxxx the problem is maven treats the entire version as a string if a dotted part is not parsable as an integer?

@jtnord
Copy link
Member Author

jtnord commented Jan 13, 2022

sorry for the noise - I ran the comparison inside Jenkins in the script console. When I use Maven libraries directly from maven 3 (3.8.4) maven does sort the version as newer, older versions of maven (2.x) sort as originally described.

@jglick
Copy link
Member

jglick commented Jan 13, 2022

I filed jenkinsci/incrementals-tools#29 to track investigation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants