-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use a versionthat works give prior releases #149
Conversation
`400.v12312312` is older than `1.1` in Maven but not jenkins. this confuses tools that use maven for version comparison, most likely dependabot et al).
@@ -1,3 +1,3 @@ | |||
-Pconsume-incrementals | |||
-Pmight-produce-incrementals | |||
-Dchangelist.format=%d.v%s | |||
-Dchangelist.format=%d-v%s |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dependabot seems to handle it well: jenkinsci/jenkins#6159 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suspect just updating the extension to 1.3 should suffice.
me goes off to file an issue against dependabot |
how would that help? it will still produce versions like |
sorry for the noise - I ran the comparison inside Jenkins in the script console. When I use Maven libraries directly from maven 3 (3.8.4) maven does sort the version as newer, older versions of maven (2.x) sort as originally described. |
I filed jenkinsci/incrementals-tools#29 to track investigation. |
400.v12312312
is older than1.1
in Maven but not jenkins. this confuses tools that use maven for version comparison, most likely dependabot et al).@jglick @Pldi23