Explicitly log not sending mails if no build result is set + fix some German umlauts apart from Javadoc warnings #44

ottlinger · 2018-10-12T12:23:37Z

While running into
https://stackoverflow.com/questions/37169100/use-jenkins-mailer-inside-pipeline-workflow
I realized that an explicit logging is needed if no build result is set.

During pipeline runs no result is set and no mail is sent out.

Add explicit logging in case of unset build result.

jvz

I'm not sure I see what you've changed here.

jvz · 2018-10-12T15:20:18Z

src/main/java/hudson/tasks/MailSender.java

        }

+        System.out.println("Not sending any mail as BuildResult is not set at all.");


You should use a logger here.

What is the "standard" way for logging in Jenkins plugins? Log4j? Slf4J? Therefore I thought that StandardOut-Logging would result in an output in the job console .....

The standard way is either directly through java.util.logging or via SLF4J.

I'm not sure if java.util.logging works, but replaced the line in the code - thanks.

ottlinger · 2018-10-12T19:56:22Z

I ran into the problem that no mails were sent from a Pipeline build as the currentBuild.result was set to null. To make this state more explicit I would like the plugin to log something.

While trying to get the builds green; i stumbled upon some Javadoc issues and tried to fixed them.

Sorry for not providing more context in the first place.

Use \u00E4 syntax for all characters.

jvz

Looks good. The reason you're not seeing any logger output is because you need to enable logging at INFO or lower for the specified logger. You can configure that via the logging properties file or through the GUI.

oleg-nenashev · 2018-10-20T12:27:39Z

Thanks @ottlinger! looks good, will merge it

oleg-nenashev

IMHO build log should be used instead of the system log in the warning message

src/main/java/hudson/tasks/MailSender.java

oleg-nenashev · 2018-10-20T12:31:50Z

Sorry, discovered the issue only during the second iteration

ottlinger · 2018-10-21T18:14:20Z

@oleg-nenashev do you mean?
listener.getLogger().println();
instead of the logger I introduced.

oleg-nenashev · 2018-10-21T18:25:21Z

Yes

…

On Sun, Oct 21, 2018, 20:14 P. Ottlinger ***@***.*** wrote: @oleg-nenashev <https://github.com/oleg-nenashev> do you mean? listener.getLogger().println(); instead of the logger I introduced. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#44 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AC3IoABZxnPeW2HC0LuCpYtdaNn_6L3mks5unLmAgaJpZM4XZX1r> .

-Organized imports after removing newly introduced logger.

ottlinger · 2018-10-21T18:28:08Z

@oleg-nenashev thanks for making the change clearer to me. As I'm not that much into Jenkins plugins I need a little bit more help :-)

oleg-nenashev · 2018-10-21T18:35:33Z

Sorry that I have not just proposed a change. Traveling, and my bandwidth is limited

…

On Sun, Oct 21, 2018, 20:28 P. Ottlinger ***@***.*** wrote: @oleg-nenashev <https://github.com/oleg-nenashev> thanks for making the change clearer to me. As I'm not that much into Jenkins plugins I need a little bit more help :-) — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#44 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AC3IoKnOqkaj5sVujim5wk-qa75NlWKlks5unLy8gaJpZM4XZX1r> .

ottlinger · 2018-10-21T18:36:37Z

np - it gave me a chance to learn more.

ottlinger · 2018-10-28T21:21:11Z

@oleg-nenashev are you ok with the current changes? Can you start the merge? Thanks.

alecharp

Could you remove the defaultGoal and add the comments in the javadoc field? Thanks.

pom.xml

src/main/java/hudson/tasks/MailAddressResolver.java

src/main/java/hudson/tasks/MailSender.java

Rename variable to comply with Java standard

ottlinger · 2018-11-28T21:42:56Z

@oleg-nenashev @alecharp @jvz
Hopefully I fixed all of the javadoc warnings so far - looking forward to your review comments

alecharp · 2018-11-29T08:04:34Z

@ottlinger the hpi:custom-war is different. It will create a war file, which would be Jenkins+plugins. hpi:run start a Jenkins instance locally. Please change the defaultGoal to hpi:run or remove it completely. Thank you for your patience with me.

You may generate a locally running instance with mvn hpi:custom-war hpi:run

Simplified extraction of changes from line break logic. (Linebreak does not seem to work properly, but will file a different issue for that)

ottlinger · 2018-12-05T10:22:07Z

Merged upstream master into my PR to make it ready for merge - pls start your reviews @oleg-nenashev @alecharp @jvz

ottlinger · 2018-12-12T21:00:46Z

ping

ottlinger · 2019-02-03T20:43:35Z

@alecharp @oleg-nenashev can you recheck the PR and merge. I just updated to the latest changes in master. (I'd be happy to get the merges into the next release).

ottlinger · 2019-02-08T10:36:50Z

ping @jvz @alecharp @oleg-nenashev - any chance this PR can get merged? Thanks.

jvz · 2019-02-08T16:03:17Z

I'm not able to merge (no permissions). Oleg or Adrien might need to do it.

alecharp · 2019-02-12T14:43:04Z

Sorry for the delay. To me the code seems fine, even if you change some imports ordering, which would have been great not to have but 🤷‍♂️

The last bit that trouble me is still the defaultGoal but it's not something major.

I'd like to give @oleg-nenashev some time to say if the modification he asked for are meeting his requirement. When that's done, I'll merge and release.

Again thank you @ottlinger for the contribution.

ottlinger · 2019-02-28T09:59:06Z

ping @oleg-nenashev - are there any other with write access to this repo that could merge this PR? Thanks.

ottlinger · 2019-03-19T16:20:46Z

ping @oleg-nenashev - anyone else with write access? Thanks for your help.

oleg-nenashev · 2019-03-19T16:42:18Z

I believe @alecharp is the current maintainer

oleg-nenashev · 2019-03-19T16:42:49Z

I can ship it since Adrien approved it

ottlinger · 2019-03-19T16:46:46Z

@alecharp can you take a look after @oleg-nenashev s comment?! Thanks 👍

ottlinger · 2019-03-29T12:18:21Z

@alecharp can you do the merge - @oleg-nenashev thanks.

alecharp · 2019-03-29T20:56:12Z

Sorry, I missed your previous notification @ottlinger. Thank you for your contribution.

ottlinger · 2019-03-29T21:04:13Z

Thanks for your help @alecharp & @oleg-nenashev

ottlinger added 7 commits October 12, 2018 14:21

Replace if by switch

ccdbe6d

Add explicit logging in case of unset build result.

Fix Javadoc warnings.

f110bad

Fix Javadoc warnings.

a137316

Result is not an enumeration, try String instead

76710d4

Add block statements.

08c4e83

Fix Javadoc warnings.

82f0307

Revert switching to switch.

d1b3fbf

ottlinger changed the title ~~Explicitly handle not sending mails of no build result is set~~ Explicitly handle not sending mails if no build result is set Oct 12, 2018

jvz reviewed Oct 12, 2018

View reviewed changes

Add defaultGoal to ease local tests.

0740ef0

ottlinger added 2 commits October 12, 2018 22:06

Fix umlauts encoding in properties file

50ec503

Use \u00E4 syntax for all characters.

Replace Sysout with logger.

a102903

ottlinger changed the title ~~Explicitly handle not sending mails if no build result is set~~ Explicitly log not sending mails if no build result is set and fix some German umlauts apart from Javadoc warnings Oct 12, 2018

jvz approved these changes Oct 12, 2018

View reviewed changes

oleg-nenashev approved these changes Oct 20, 2018

View reviewed changes

oleg-nenashev requested changes Oct 20, 2018

View reviewed changes

src/main/java/hudson/tasks/MailSender.java Outdated Show resolved Hide resolved

Adapt log message to include build name

d8ce3d2

Switched message to listener instead.

c522ded

-Organized imports after removing newly introduced logger.

Fix javadoc warnings.

1e5f338

alecharp requested changes Nov 27, 2018

View reviewed changes

Downgrade to verify as defaultGoal.

62e809f

ottlinger added 4 commits November 28, 2018 21:57

Fix javadoc errors and remove unthrown exception.

282c0df

Fix javadoc warnings

8e281d0

Rename variable to comply with Java standard

Fix javadoc errors.

354fb52

Fix remaining javadoc warnings

5ecec0d

ottlinger added 3 commits December 4, 2018 23:44

Update default goal to hpi:run

62f44e5

You may generate a locally running instance with mvn hpi:custom-war hpi:run

Refactoring changes header

0cc06bd

Simplified extraction of changes from line break logic. (Linebreak does not seem to work properly, but will file a different issue for that)

Merge remote-tracking branch 'upstream/master'

55abb1f

Merge remote-tracking branch 'upstream/master'

e53bcb0

alecharp approved these changes Feb 12, 2019

View reviewed changes

alecharp merged commit 6b8ea83 into jenkinsci:master Mar 29, 2019

oleg-nenashev changed the title ~~Explicitly log not sending mails if no build result is set and fix some German umlauts apart from Javadoc warnings~~ Explicitly log not sending mails if no build result is set + fix some German umlauts apart from Javadoc warnings Jul 26, 2019

oleg-nenashev added the enhancement label Jul 26, 2019

tsparber mentioned this pull request Aug 13, 2019

[JENKINS-58768] Fix send test mail after adding JCasC compatibility #60

Merged

jglick mentioned this pull request Dec 28, 2021

Update deps #138

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Explicitly log not sending mails if no build result is set + fix some German umlauts apart from Javadoc warnings #44

Explicitly log not sending mails if no build result is set + fix some German umlauts apart from Javadoc warnings #44

ottlinger commented Oct 12, 2018

jvz left a comment

jvz Oct 12, 2018

ottlinger Oct 12, 2018

jvz Oct 12, 2018

ottlinger Oct 12, 2018

ottlinger commented Oct 12, 2018

jvz left a comment

oleg-nenashev commented Oct 20, 2018

oleg-nenashev left a comment

oleg-nenashev commented Oct 20, 2018

ottlinger commented Oct 21, 2018

oleg-nenashev commented Oct 21, 2018 via email

ottlinger commented Oct 21, 2018

oleg-nenashev commented Oct 21, 2018 via email

ottlinger commented Oct 21, 2018

ottlinger commented Oct 28, 2018

alecharp left a comment

ottlinger commented Nov 28, 2018

alecharp commented Nov 29, 2018

ottlinger commented Dec 5, 2018

ottlinger commented Dec 12, 2018

ottlinger commented Feb 3, 2019

ottlinger commented Feb 8, 2019

jvz commented Feb 8, 2019

alecharp commented Feb 12, 2019

ottlinger commented Feb 28, 2019

ottlinger commented Mar 19, 2019

oleg-nenashev commented Mar 19, 2019

oleg-nenashev commented Mar 19, 2019

ottlinger commented Mar 19, 2019

ottlinger commented Mar 29, 2019

alecharp commented Mar 29, 2019

ottlinger commented Mar 29, 2019

		}

		System.out.println("Not sending any mail as BuildResult is not set at all.");

Explicitly log not sending mails if no build result is set + fix some German umlauts apart from Javadoc warnings #44

Explicitly log not sending mails if no build result is set + fix some German umlauts apart from Javadoc warnings #44

Conversation

ottlinger commented Oct 12, 2018

jvz left a comment

Choose a reason for hiding this comment

jvz Oct 12, 2018

Choose a reason for hiding this comment

ottlinger Oct 12, 2018

Choose a reason for hiding this comment

jvz Oct 12, 2018

Choose a reason for hiding this comment

ottlinger Oct 12, 2018

Choose a reason for hiding this comment

ottlinger commented Oct 12, 2018

jvz left a comment

Choose a reason for hiding this comment

oleg-nenashev commented Oct 20, 2018

oleg-nenashev left a comment

Choose a reason for hiding this comment

oleg-nenashev commented Oct 20, 2018

ottlinger commented Oct 21, 2018

oleg-nenashev commented Oct 21, 2018 via email

ottlinger commented Oct 21, 2018

oleg-nenashev commented Oct 21, 2018 via email

ottlinger commented Oct 21, 2018

ottlinger commented Oct 28, 2018

alecharp left a comment

Choose a reason for hiding this comment

ottlinger commented Nov 28, 2018

alecharp commented Nov 29, 2018

ottlinger commented Dec 5, 2018

ottlinger commented Dec 12, 2018

ottlinger commented Feb 3, 2019

ottlinger commented Feb 8, 2019

jvz commented Feb 8, 2019

alecharp commented Feb 12, 2019

ottlinger commented Feb 28, 2019

ottlinger commented Mar 19, 2019

oleg-nenashev commented Mar 19, 2019

oleg-nenashev commented Mar 19, 2019

ottlinger commented Mar 19, 2019

ottlinger commented Mar 29, 2019

alecharp commented Mar 29, 2019

ottlinger commented Mar 29, 2019