Use String#join where possible (#14)

jenkinsci · Aug 4, 2022 · 17a4ff6 · 17a4ff6
1 parent 4f201b3
commit 17a4ff6
Showing 1 changed file with 3 additions and 14 deletions.
diff --git a/src/main/java/org/kohsuke/stapler/TaglibDocMojo.java b/src/main/java/org/kohsuke/stapler/TaglibDocMojo.java
@@ -195,16 +195,16 @@ private void scanTagLibs(File dir, String uri, Tags tags) throws IOException {
     private void parseTagLib(File dir, String uri, Library lib) throws IOException {
         getLog().info("Processing "+dir);
 
-        List markerFile = FileUtils.readLines(new File(dir, "taglib"));
+        List<String> markerFile = FileUtils.readLines(new File(dir, "taglib"));
         if (markerFile.size() == 0) {
             markerFile.add(uri);
         }
 
         // write the attributes
-        lib.name(markerFile.get(0).toString());
+        lib.name(markerFile.get(0));
         lib.prefix(uri.substring(uri.lastIndexOf('/')+1)).uri(uri);
         // doc
-        lib.doc()._pcdata(join(markerFile));
+        lib.doc()._pcdata(String.join("\n", markerFile));
 
         File[] tagFiles = dir.listFiles(f -> f.getName().endsWith(".jelly"));
         if (tagFiles == null) {
@@ -252,17 +252,6 @@ private void parseTagFile(File tagFile, Tag tag) throws IOException {
         }
     }
 
-    private String join(List list) {
-        StringBuilder buf = new StringBuilder();
-        for (Object item : list) {
-            if (buf.length() > 0) {
-                buf.append('\n');
-            }
-            buf.append(item);
-        }
-        return buf.toString();
-    }
-
 //
 // MavenReport implementation
 //