Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump bom and jenkins version #20

Merged
merged 3 commits into from
Jul 26, 2022
Merged

Conversation

jetersen
Copy link
Member

unblock jenkinsci/bom#1275

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@jetersen jetersen requested a review from a team as a code owner July 22, 2022 22:04
mina-sshd-api-core/pom.xml Outdated Show resolved Hide resolved
@jetersen
Copy link
Member Author

Confirmed to work in jenkinsci/bom#1275 but waiting for release of jenkinsci/ssh-credentials-plugin#142

@jetersen jetersen marked this pull request as ready for review July 25, 2022 16:23
@jetersen
Copy link
Member Author

@jglick @Dohbedoh should we pin it here first or let bom update it, first? 🤔

If you want to pin here, this is ready for release.

@Dohbedoh
Copy link
Contributor

is there a benefit of letting bom update it ? Otherwise, I am good to just release this.

@Dohbedoh Dohbedoh added dependencies Pull requests that update a dependency file bug Something isn't working labels Jul 25, 2022
@jetersen
Copy link
Member Author

jetersen commented Jul 25, 2022

I think @jglick approach for some of the pipeline libraries has been to pin it locally first. Than once both are in bom remove it from here and release whenever.

So lets go with a release 👏

@Dohbedoh Dohbedoh merged commit 8e25ce9 into jenkinsci:main Jul 26, 2022
@Dohbedoh
Copy link
Contributor

@jetersen https://github.com/jenkinsci/mina-sshd-api-plugin/releases/tag/2.8.0-36.v8e25ce90d4b_1

@jetersen
Copy link
Member Author

@Dohbedoh thanks :)

@HuangBaiDa
Copy link

what not have dependency jenkins version in the here?

@@ -49,6 +49,7 @@
<groupId>org.jenkins-ci.plugins</groupId>
<artifactId>ssh-credentials</artifactId>
<optional>true</optional>
<version>277.280.v1e86b_7d0056b_</version>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My recommendation is to instead add this to the dependencyManagement section with a TODO comment requesting that the dependency entry be deleted once bom is used in a sufficiently new version. Then it is clear to anyone refreshing the plugin that there is something to be cleaned up.

@jglick
Copy link
Member

jglick commented Jul 14, 2023

@Dohbedoh added dependencies bug labels

For this sort of thing we use the developer label, FYI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants