-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bump bom and jenkins version #20
Conversation
Confirmed to work in jenkinsci/bom#1275 but waiting for release of jenkinsci/ssh-credentials-plugin#142 |
is there a benefit of letting bom update it ? Otherwise, I am good to just release this. |
I think @jglick approach for some of the pipeline libraries has been to pin it locally first. Than once both are in bom remove it from here and release whenever. So lets go with a release 👏 |
@Dohbedoh thanks :) |
what not have dependency jenkins version in the here? |
@@ -49,6 +49,7 @@ | |||
<groupId>org.jenkins-ci.plugins</groupId> | |||
<artifactId>ssh-credentials</artifactId> | |||
<optional>true</optional> | |||
<version>277.280.v1e86b_7d0056b_</version> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My recommendation is to instead add this to the dependencyManagement
section with a TODO
comment requesting that the dependency
entry be deleted once bom
is used in a sufficiently new version. Then it is clear to anyone refreshing the plugin that there is something to be cleaned up.
For this sort of thing we use the |
unblock jenkinsci/bom#1275