Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bump bom and jenkins version #20

Merged
merged 3 commits into from
Jul 26, 2022
Merged

bump bom and jenkins version #20

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0ea0ae3
bump bom and jenkins version
jetersen Jul 22, 2022
dba8581
pin ssh-credentials
jetersen Jul 22, 2022
6c9c283
use released ssh credentials
jetersen Jul 25, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions mina-sshd-api-core/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<?xml version="1.0" encoding="UTF-8"?>
<project xmlns="http://maven.apache.org/POM/4.0.0"
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
<project xmlns="http://maven.apache.org/POM/4.0.0"
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
<modelVersion>4.0.0</modelVersion>

Expand All @@ -18,7 +18,7 @@
This plugin provides the Apache Mina SSHD Core library to plugins.
</description>
<url>https://github.com/jenkinsci/mina-sshd-api-plugin</url>

<dependencies>
<dependency>
<groupId>io.jenkins.plugins.mina-sshd-api</groupId>
Expand Down Expand Up @@ -49,6 +49,7 @@
<groupId>org.jenkins-ci.plugins</groupId>
<artifactId>ssh-credentials</artifactId>
<optional>true</optional>
<version>277.280.v1e86b_7d0056b_</version>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My recommendation is to instead add this to the dependencyManagement section with a TODO comment requesting that the dependency entry be deleted once bom is used in a sufficiently new version. Then it is clear to anyone refreshing the plugin that there is something to be cleaned up.

</dependency>
</dependencies>
</project>
18 changes: 9 additions & 9 deletions pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
This plugin provides the Apache Mina SSHD Core library to plugins.
</description>
<url>https://github.com/jenkinsci/mina-sshd-api-plugin</url>

<licenses>
<license>
<name>The MIT license</name>
Expand All @@ -42,22 +42,22 @@
<url>https://github.com/${gitHubRepo}</url>
<tag>${scmTag}</tag>
</scm>

<properties>
<revision>2.8.0</revision>
<changelist>999999-SNAPSHOT</changelist>
<gitHubRepo>jenkinsci/mina-sshd-api-plugin</gitHubRepo>
<jenkins.version>2.289.3</jenkins.version>
<jenkins.version>2.319.3</jenkins.version>
<autoVersionSubmodules>true</autoVersionSubmodules>
</properties>

<repositories>
<repository>
<id>repo.jenkins-ci.org</id>
<url>https://repo.jenkins-ci.org/public/</url>
</repository>
</repositories>

<pluginRepositories>
<pluginRepository>
<id>repo.jenkins-ci.org</id>
Expand All @@ -71,13 +71,13 @@
<module>mina-sshd-api-scp</module>
<module>mina-sshd-api-sftp</module>
</modules>

<dependencyManagement>
<dependencies>
<dependency>
<groupId>io.jenkins.tools.bom</groupId>
<artifactId>bom-2.289.x</artifactId>
<version>1466.v85a_616ea_b_87c</version>
<artifactId>bom-2.319.x</artifactId>
<version>1508.v4b_d09ff0e893</version>
<type>pom</type>
<scope>import</scope>
</dependency>
Expand All @@ -93,4 +93,4 @@
</dependency>
</dependencies>
</dependencyManagement>
</project>
</project>