This repository has been archived by the owner on May 28, 2024. It is now read-only.
Add protection from CSRF #291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juanmafabbri
reviewed
Nov 7, 2023
| @@ -58,6 +59,7 @@ class Nxrm2Configuration | |||
| } | |||
|
|
|||
| @Override | |||
| @POST | |||
| FormValidation doVerifyCredentials(@QueryParameter String serverUrl, @QueryParameter String credentialsId) | |||
There was a problem hiding this comment.
Based on the specification, why would it not be necessary to check permissions for the user such as Jenkins.get().checkPermission(Jenkins.ADMINISTER);?
There was a problem hiding this comment.
Good catch! I'll add that too.
eduard-tita
deleted the
SEC-763-Vulnerabilities-Reported-by-Jenkins-Team
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nexus Platform plugin does not perform permission checks allowing user with Overall/Read permission to connect to an attacker-specified URL.
Two of the three endpoints also lead to a Credentials leaking due to the presence of the
credentialsIdparameter which can be used by an attacker to receive a request with username and password base64 encoded inside the headers as Basic Authentication.Additionally, these HTTP endpoints do not require POST request, resulting in a cross-site request forgery (CSRF) vulnerability.
Culprit
NxiqConfiguration.groovy#L126
Nxrm2Configuration.groovy#L61
Nxrm3Configuration.groovy#L83
Recommendation
Links
Jira: https://sonatype.atlassian.net/browse/SEC-763
Build: https://jenkins.ci.sonatype.dev/job/integrations/job/jenkins/job/feature-snapshots/job/SEC-763-Vulnerabilities-Reported-by-Jenkins-Team/