Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-25218] - Hardening of FifoBuffer operation logic #132

Conversation

oleg-nenashev
Copy link
Member

It is a version of #100 submitted against the master branch

The most of JENKINS-25218 has been handled in 3ea38c8 by @andresrc. But there are still potential issues in the FifoBuffer behavior.

Changes:

  • - Add closedRequested and handle it in multiple threads, which used to prevent close() calls previously
  • Fix potential NPE in FifoBuffer receiver
  • Do not rely on external code when we receive ClosedChannelException from the underlying channel

@oleg-nenashev oleg-nenashev changed the title Bug/jenkins 25218 fifobuffer deadlock [JENKINS-25218] - Hardening of FifoBuffer operation logic Nov 17, 2016
@oleg-nenashev
Copy link
Member Author

#100 has been berged, this guy is not required anymore

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant