Make SecureGroovyScriptTest work in PCT with Lockable Resources
#352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any chance this could be merged so that we can add Lockable Resources to BOM compatibility runs? |
|
@car-roll Any chance this could be merged in order to improve BOM compatibility runs? |
car-roll
approved these changes
Nov 16, 2021
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See jenkinsci/bom#552. While trying to add Lockable Resources to the BOM, I started tripping on this test. The test assumes there is one
._scriptelement in the form, but when Lockable Resources is present there is another one earlier on the page for Lockable Resources. The test finds that one instead (it's looking for the first one) and then goes off the rails. Instead I'm having the test pick the last one rather than the first one, which in this case is the one that it's looking for. This gets the test to pass both with and without Lockable Resources present.