[JENKINS-34741] Reproduced problem in test #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request originates from a CloudBees employee. At CloudBees, we require that all pull requests be reviewed by other CloudBees employees before we seek to have the change accepted. If you want to learn more about our process please see this explanation. |
|
🐝 Yeah, short of whitelisting named parameter constructors in a blanket way, I'm not sure what the solution would be. |
|
According to this the sandbox should be checking whitelists for the default constructor and then all mentioned setters (or I guess field accesses). Yet another case of the sandbox not telling us what it is really running; cf. jenkinsci/groovy-sandbox#7. |
|
🐝, but we need to create a JIRA issues and reference it before merging |
jglick
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JENKINS-34741
@oleg-nenashev passed on a report of this. Not yet obvious to me how to fix, but useful to have the test case recorded.
@reviewbybees