From e873d73c60cece5771cf19b37bdb33b18c741b75 Mon Sep 17 00:00:00 2001 From: Dan Siegel Date: Tue, 21 May 2024 13:16:50 -0600 Subject: [PATCH] feat: make UnoFeatures ignore casing --- src/Uno.Sdk/targets/Uno.Common.targets | 12 +++---- ...ns.Implicit.Packages.ProjectSystem.targets | 36 +++++++++---------- src/Uno.Sdk/targets/Uno.Features.targets | 4 +-- ...mplicit.Packages.ProjectSystem.Uno.targets | 10 +++--- ...plicit.Packages.ProjectSystem.Wasm.targets | 2 +- ...t.Packages.ProjectSystem.WinAppSdk.targets | 2 +- ...no.Implicit.Packages.ProjectSystem.targets | 34 +++++++++--------- 7 files changed, 50 insertions(+), 50 deletions(-) diff --git a/src/Uno.Sdk/targets/Uno.Common.targets b/src/Uno.Sdk/targets/Uno.Common.targets index b3d214c41362..0d10b452b90e 100644 --- a/src/Uno.Sdk/targets/Uno.Common.targets +++ b/src/Uno.Sdk/targets/Uno.Common.targets @@ -120,17 +120,17 @@ - + - - + + - - + + - + diff --git a/src/Uno.Sdk/targets/Uno.Extensions.Implicit.Packages.ProjectSystem.targets b/src/Uno.Sdk/targets/Uno.Extensions.Implicit.Packages.ProjectSystem.targets index 89ade2a88a79..71ca753d665b 100644 --- a/src/Uno.Sdk/targets/Uno.Extensions.Implicit.Packages.ProjectSystem.targets +++ b/src/Uno.Sdk/targets/Uno.Extensions.Implicit.Packages.ProjectSystem.targets @@ -8,46 +8,46 @@ <_UseUnoExtensions>$(UnoFeatures.Contains(';Extensions;')) - + <_UnoProjectSystemPackageReference Include="Uno.Extensions.Authentication.MSAL.WinUI" ProjectSystem="true" /> <_UnoProjectSystemPackageReference Include="Microsoft.Identity.Client" ProjectSystem="true" /> <_UnoProjectSystemPackageReference Include="Uno.WinUI.MSAL" ProjectSystem="true" /> - + <_UnoProjectSystemPackageReference Include="Uno.Extensions.Authentication.Oidc.WinUI" ProjectSystem="true" /> - + <_UnoProjectSystemPackageReference Include="Uno.Extensions.Authentication.WinUI" ProjectSystem="true" /> - + <_UnoProjectSystemPackageReference Include="Uno.Extensions.Configuration" ProjectSystem="true" /> - + <_UnoProjectSystemPackageReference Include="Uno.Extensions.Core.WinUI" ProjectSystem="true" /> - + <_UnoProjectSystemPackageReference Include="Uno.Extensions.Hosting.WinUI" ProjectSystem="true" /> - + <_UnoProjectSystemPackageReference Include="Uno.Extensions.Http.WinUI" ProjectSystem="true" /> <_UnoProjectSystemPackageReference Include="Uno.Extensions.Http.Refit" ProjectSystem="true" /> - + <_UnoProjectSystemPackageReference Include="Uno.Extensions.Localization.WinUI" ProjectSystem="true" /> - + <_UnoProjectSystemPackageReference Include="Uno.Extensions.Logging.WinUI" ProjectSystem="true" /> - + <_UnoProjectSystemPackageReference Include="Uno.Extensions.Maui.WinUI" ProjectSystem="true" /> <_UnoProjectSystemPackageReference Include="Uno.Extensions.Maui.WinUI.Markup" ProjectSystem="true" Condition="$(UnoFeatures.Contains('CSharpMarkup'))" /> <_UnoProjectSystemPackageReference Include="Microsoft.Maui.Controls" ProjectSystem="true" /> @@ -63,28 +63,28 @@ <_UnoProjectSystemPackageReference Include="Xamarin.AndroidX.Collection.Ktx" ProjectSystem="true" Condition="$(IsAndroid) == 'true'" /> - + <_UnoProjectSystemPackageReference Include="Uno.Extensions.Navigation.WinUI" ProjectSystem="true" /> - <_UnoProjectSystemPackageReference Include="Uno.Extensions.Navigation.WinUI.Markup" ProjectSystem="true" Condition="$(UnoFeatures.Contains('CSharpMarkup'))"/> - <_UnoProjectSystemPackageReference Include="Uno.Extensions.Navigation.Toolkit.WinUI" ProjectSystem="true" Condition="$(UnoFeatures.Contains('Toolkit'))"/> + <_UnoProjectSystemPackageReference Include="Uno.Extensions.Navigation.WinUI.Markup" ProjectSystem="true" Condition="$(UnoFeatures.Contains(';csharpmarkup;'))"/> + <_UnoProjectSystemPackageReference Include="Uno.Extensions.Navigation.Toolkit.WinUI" ProjectSystem="true" Condition="$(UnoFeatures.Contains(';toolkit;'))"/> - + <_UnoProjectSystemPackageReference Include="Uno.Extensions.Reactive.WinUI" ProjectSystem="true" /> <_UnoProjectSystemPackageReference Include="Uno.Extensions.Reactive.Messaging" ProjectSystem="true" /> - <_UnoProjectSystemPackageReference Include="Uno.Extensions.Reactive.WinUI.Markup" ProjectSystem="true" Condition="$(UnoFeatures.Contains('CSharpMarkup'))" /> + <_UnoProjectSystemPackageReference Include="Uno.Extensions.Reactive.WinUI.Markup" ProjectSystem="true" Condition="$(UnoFeatures.Contains(';csharpmarkup;'))" /> - + <_UnoProjectSystemPackageReference Include="Uno.Extensions.Serialization.Http" ProjectSystem="true" /> <_UnoProjectSystemPackageReference Include="Uno.Extensions.Serialization.Refit" ProjectSystem="true" /> - + <_UnoProjectSystemPackageReference Include="Uno.Extensions.Logging.Serilog" ProjectSystem="true" /> - + <_UnoProjectSystemPackageReference Include="Uno.Extensions.Storage.WinUI" ProjectSystem="true" /> diff --git a/src/Uno.Sdk/targets/Uno.Features.targets b/src/Uno.Sdk/targets/Uno.Features.targets index 2765451715c7..744e9103396a 100644 --- a/src/Uno.Sdk/targets/Uno.Features.targets +++ b/src/Uno.Sdk/targets/Uno.Features.targets @@ -1,13 +1,13 @@ - $([System.Text.RegularExpressions.Regex]::Replace($(UnoFeatures), '\s', '')) + $([System.Text.RegularExpressions.Regex]::Replace($(UnoFeatures), '\s', '').ToLower()) ; ;$(UnoFeatures) $(UnoFeatures); - + true diff --git a/src/Uno.Sdk/targets/Uno.Implicit.Packages.ProjectSystem.Uno.targets b/src/Uno.Sdk/targets/Uno.Implicit.Packages.ProjectSystem.Uno.targets index 5c9fe2908b87..3f80ad6cb4fd 100644 --- a/src/Uno.Sdk/targets/Uno.Implicit.Packages.ProjectSystem.Uno.targets +++ b/src/Uno.Sdk/targets/Uno.Implicit.Packages.ProjectSystem.Uno.targets @@ -4,20 +4,20 @@ in order for VS and C# Dev Kit to show nuget references in their respective solution explorers. The version is not required, and VS/Code waits for some design-time targets to be executed to evaluate it. --> - + <_UnoProjectSystemPackageReference Include="Uno.WinUI.Lottie" ProjectSystem="true" /> - + <_UnoProjectSystemPackageReference Include="SkiaSharp.Views.Uno.WinUI" ProjectSystem="true"/> - + <_UnoProjectSystemPackageReference Include="Uno.WinUI.Svg" ProjectSystem="true" /> - <_UnoProjectSystemPackageReference Include="SkiaSharp.Skottie" ProjectSystem="true" Condition="$(UnoFeatures.Contains(';Lottie;')) OR $(UnoFeatures.Contains(';Material;')) OR $(UnoFeatures.Contains(';Cupertino;'))" /> - <_UnoProjectSystemPackageReference Include="Svg.Skia" ProjectSystem="true" Condition="$(UnoFeatures.Contains(';Svg;')) AND $(IsUnoHead) == 'true'" /> + <_UnoProjectSystemPackageReference Include="SkiaSharp.Skottie" ProjectSystem="true" Condition="$(UnoFeatures.Contains(';lottie;')) OR $(UnoFeatures.Contains(';material;')) OR $(UnoFeatures.Contains(';cupertino;'))" /> + <_UnoProjectSystemPackageReference Include="Svg.Skia" ProjectSystem="true" Condition="$(UnoFeatures.Contains(';svg;')) AND $(IsUnoHead) == 'true'" /> diff --git a/src/Uno.Sdk/targets/Uno.Implicit.Packages.ProjectSystem.Wasm.targets b/src/Uno.Sdk/targets/Uno.Implicit.Packages.ProjectSystem.Wasm.targets index 384090267c71..5b04084e9211 100644 --- a/src/Uno.Sdk/targets/Uno.Implicit.Packages.ProjectSystem.Wasm.targets +++ b/src/Uno.Sdk/targets/Uno.Implicit.Packages.ProjectSystem.Wasm.targets @@ -8,7 +8,7 @@ <_UnoProjectSystemPackageReference Include="Uno.WinUI.WebAssembly" ProjectSystem="true" /> - <_UnoProjectSystemPackageReference Include="Uno.WinUI.MediaPlayer.WebAssembly" ProjectSystem="true" Condition="$(UnoFeatures.Contains(';MediaElement;'))"/> + <_UnoProjectSystemPackageReference Include="Uno.WinUI.MediaPlayer.WebAssembly" ProjectSystem="true" Condition="$(UnoFeatures.Contains(';mediaelement;'))"/> <_UnoProjectSystemPackageReference Include="Microsoft.Windows.Compatibility" ProjectSystem="true" /> <_UnoProjectSystemPackageReference Include="Uno.Extensions.Logging.WebAssembly.Console" ProjectSystem="true" /> <_UnoProjectSystemPackageReference Include="Uno.Wasm.Bootstrap" ProjectSystem="true" /> diff --git a/src/Uno.Sdk/targets/Uno.Implicit.Packages.ProjectSystem.WinAppSdk.targets b/src/Uno.Sdk/targets/Uno.Implicit.Packages.ProjectSystem.WinAppSdk.targets index 6805b155cf92..c0e8ade61337 100644 --- a/src/Uno.Sdk/targets/Uno.Implicit.Packages.ProjectSystem.WinAppSdk.targets +++ b/src/Uno.Sdk/targets/Uno.Implicit.Packages.ProjectSystem.WinAppSdk.targets @@ -10,7 +10,7 @@ <_UnoProjectSystemPackageReference Include="Uno.Core.Extensions.Logging.Singleton" ProjectSystem="true" Condition="$(_IsExecutable) == 'true'"/> - + <_UnoProjectSystemPackageReference Include="SkiaSharp.Views.WinUI" ProjectSystem="true" /> diff --git a/src/Uno.Sdk/targets/Uno.Implicit.Packages.ProjectSystem.targets b/src/Uno.Sdk/targets/Uno.Implicit.Packages.ProjectSystem.targets index 39ec1a59b264..34d3482e7d36 100644 --- a/src/Uno.Sdk/targets/Uno.Implicit.Packages.ProjectSystem.targets +++ b/src/Uno.Sdk/targets/Uno.Implicit.Packages.ProjectSystem.targets @@ -29,49 +29,49 @@ - + <_UnoProjectSystemPackageReference Include="Uno.WinUI.Maps" ProjectSystem="true" /> - + <_UnoProjectSystemPackageReference Include="Uno.WinUI.Foldable" ProjectSystem="true" /> - + <_UnoProjectSystemPackageReference Include="Uno.WinUI.Markup" ProjectSystem="true" /> <_UnoProjectSystemPackageReference Include="Uno.Extensions.Markup.Generators" ProjectSystem="true" /> - + <_UnoProjectSystemPackageReference Include="Uno.Toolkit.WinUI" ProjectSystem="true" /> - <_UnoProjectSystemPackageReference Include="Uno.Toolkit.WinUI.Markup" ProjectSystem="true" Condition="$(UnoFeatures.Contains(';CSharpMarkup;'))" /> - <_UnoProjectSystemPackageReference Include="Uno.Toolkit.Skia.WinUI" ProjectSystem="true" Condition="$(UnoFeatures.Contains(';Skia;'))" /> - <_UnoProjectSystemPackageReference Include="Uno.Toolkit.WinUI.Cupertino" ProjectSystem="true" Condition="$(UnoFeatures.Contains(';Cupertino;'))" /> - <_UnoProjectSystemPackageReference Include="Uno.Toolkit.WinUI.Material" ProjectSystem="true" Condition="$(UnoFeatures.Contains(';Material;'))" /> - <_UnoProjectSystemPackageReference Include="Uno.Toolkit.WinUI.Material.Markup" ProjectSystem="true" Condition="$(UnoFeatures.Contains(';Material;')) AND $(UnoFeatures.Contains(';CSharpMarkup;'))" /> + <_UnoProjectSystemPackageReference Include="Uno.Toolkit.WinUI.Markup" ProjectSystem="true" Condition="$(UnoFeatures.Contains(';csharpmarkup;'))" /> + <_UnoProjectSystemPackageReference Include="Uno.Toolkit.Skia.WinUI" ProjectSystem="true" Condition="$(UnoFeatures.Contains(';skia;'))" /> + <_UnoProjectSystemPackageReference Include="Uno.Toolkit.WinUI.Cupertino" ProjectSystem="true" Condition="$(UnoFeatures.Contains(';cupertino;'))" /> + <_UnoProjectSystemPackageReference Include="Uno.Toolkit.WinUI.Material" ProjectSystem="true" Condition="$(UnoFeatures.Contains(';material;'))" /> + <_UnoProjectSystemPackageReference Include="Uno.Toolkit.WinUI.Material.Markup" ProjectSystem="true" Condition="$(UnoFeatures.Contains(';material;')) AND $(UnoFeatures.Contains(';csharpmarkup;'))" /> - + <_UnoProjectSystemPackageReference Include="Uno.Material.WinUI" ProjectSystem="true" /> - <_UnoProjectSystemPackageReference Include="Uno.Material.WinUI.Markup" ProjectSystem="true" Condition="$(UnoFeatures.Contains(';CSharpMarkup;'))" /> - <_UnoProjectSystemPackageReference Include="Uno.Themes.WinUI.Markup" ProjectSystem="true" Condition="$(UnoFeatures.Contains(';CSharpMarkup;'))" /> + <_UnoProjectSystemPackageReference Include="Uno.Material.WinUI.Markup" ProjectSystem="true" Condition="$(UnoFeatures.Contains(';csharpmarkup;'))" /> + <_UnoProjectSystemPackageReference Include="Uno.Themes.WinUI.Markup" ProjectSystem="true" Condition="$(UnoFeatures.Contains(';csharpmarkup;'))" /> - + <_UnoProjectSystemPackageReference Include="Uno.Cupertino.WinUI" ProjectSystem="true" /> - + <_UnoProjectSystemPackageReference Include="Prism.Uno.WinUI" ProjectSystem="true" Condition="!$(_IsExecutable)" /> <_UnoProjectSystemPackageReference Include="Prism.DryIoc.Uno.WinUI" ProjectSystem="true" Condition="$(_IsExecutable)" /> - <_UnoProjectSystemPackageReference Include="Prism.Uno.WinUI.Markup" ProjectSystem="true" Condition="$(UnoFeatures.Contains(';CSharpMarkup;'))" /> + <_UnoProjectSystemPackageReference Include="Prism.Uno.WinUI.Markup" ProjectSystem="true" Condition="$(UnoFeatures.Contains(';csharpmarkup;'))" /> - + <_UnoProjectSystemPackageReference Include="Uno.Dsp.Tasks" ProjectSystem="true" /> - + <_UnoProjectSystemPackageReference Include="CommunityToolkit.Mvvm" ProjectSystem="true" />