Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(icons): replace deprecated nerd-fonts icons #2583

Closed
wants to merge 1 commit into from
Closed

fix(icons): replace deprecated nerd-fonts icons #2583

wants to merge 1 commit into from

Conversation

carlosala
Copy link

  • PR Description
    Replace deprecated nerd-fonts icons from v3 on.

  • Please check if the PR fulfills these requirements

  • Cheatsheets are up-to-date (run go run scripts/cheatsheet/main.go generate)
  • Code has been formatted (see here)
  • Tests have been added/updated (see here for the integration test guide)
  • Text is internationalised (see here)
  • Docs (specifically docs/Config.md) have been updated if necessary
  • You've read through your own file changes for silly mistakes etc

@David-Else
Copy link
Contributor

David-Else commented May 4, 2023

Brilliant! This fixes the super annoying font problems I have had with v2.3.3 Symbols-2048-em Nerd Font Complete Mono.ttf in Kitty.

I tried copying and pasting the new and old from this pull request in the terminal, and it looks much better:

Screenshot from 2023-05-04 11-58-35

Is this the same as #2593, different author @jtrv ?

Also, check out this related issue #2236, which will hopefully be closable when this is merged.

@jtrv
Copy link

jtrv commented May 5, 2023

@David-Else In my PR I changed the nerdfont character in the comment next to the code point in the same way this PR does, but the code points here are invalid. When I tried using the correct code points on my branch they didn't seem to be read correctly, so I've closed my pr until I can figure out how to get it working properly.

@gotgenes
Copy link

gotgenes commented May 6, 2023

I made an alternative PR that uses higher order unicode code points. #2604

@carlosala
Copy link
Author

Closed in favour of #2604

@carlosala carlosala closed this May 6, 2023
@carlosala carlosala deleted the fix-nerdfonts branch May 6, 2023 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants