From 63353f76874823f8207aac0b23280c026d16ab20 Mon Sep 17 00:00:00 2001 From: Simen Bekkhus Date: Mon, 10 Feb 2020 13:15:07 +0100 Subject: [PATCH] do not test node 8 as berry doesn't support it --- .circleci/config.yml | 17 ----------------- .github/workflows/nodejs.yml | 3 +-- 2 files changed, 1 insertion(+), 19 deletions(-) diff --git a/.circleci/config.yml b/.circleci/config.yml index de7f22ec2fa5..a6a119b903d0 100644 --- a/.circleci/config.yml +++ b/.circleci/config.yml @@ -18,22 +18,6 @@ aliases: version: 2 jobs: - test-node-8: - working_directory: ~/jest - docker: - - image: circleci/node:8 - steps: - - checkout - - run: - command: yarn remove-prettier-dep - - restore-cache: *restore-cache - - run: *install - - save-cache: *save-cache - - run: - command: yarn test-ci-partial - - store_test_results: - path: reports/junit - test-node-10: working_directory: ~/jest docker: @@ -120,7 +104,6 @@ workflows: version: 2 build-and-deploy: jobs: - - test-node-8 - test-node-10 - test-node-12 - test-node-13 # current diff --git a/.github/workflows/nodejs.yml b/.github/workflows/nodejs.yml index 834287fda8b2..de334bd32a62 100644 --- a/.github/workflows/nodejs.yml +++ b/.github/workflows/nodejs.yml @@ -54,8 +54,7 @@ jobs: strategy: fail-fast: false matrix: - # https://github.com/actions/setup-node/issues/27 - node-version: [8.17.0, 10.x, 12.x, 13.x] + node-version: [10.x, 12.x, 13.x] os: [ubuntu-latest, macOS-latest, windows-latest] runs-on: ${{ matrix.os }}