Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A timeout in a beforeEach continues executing the dependant test cases #8442

Closed
baskillen opened this issue May 8, 2019 · 7 comments
Closed

Comments

@baskillen
Copy link

baskillen commented May 8, 2019

🐛 Bug Report

When a beforeEach times out, the succeeding tests in the describe are still being executed. This causes confusion as it is not very clear that the beforeEach has timed out and not the actual test.

To Reproduce

Steps to reproduce the behavior:

describe('should not run it if beforeEach times out', () => {
  beforeEach(done => {});

  it('this text should not be printed', () => {
    console.log('SHOULD NOT HAPPEN');
  });
});

Expected behavior

When a beforeEach times out, it would be nice if it was clearly stated that the problem happened within the beforeEach.

I would also expect the tests that depend on the beforeEach not to be executed.

Link to repl or repo (highly encouraged)

https://repl.it/repls/ImmaculateHumongousLava

Run npx envinfo --preset jest

Paste the results here:

System:
    OS: macOS 10.14.4
    CPU: (8) x64 Intel(R) Core(TM) i7-8559U CPU @ 2.70GHz
  Binaries:
    Node: 10.15.0 - /usr/local/bin/node
    Yarn: 1.15.2 - ~/.yarn/bin/yarn
    npm: 6.7.0 - ~/.npm/global/bin/npm
  npmPackages:
    jest: ^24.8.0 => 24.8.0
@Mavrin
Copy link

Mavrin commented May 17, 2019

Also it doesn't work for case with rejected promise https://repl.it/@Mavrin/MaroonUntidyMemory

describe('should not run it if beforeEach times out', () => {
  beforeEach(async () => {
    await Promise.reject();
  });

  it('this text should not be printed', () => {
    console.log('SHOULD NOT HAPPEN');
  });
});

@marcelijanowski
Copy link

Any update on this issue?

@nickpalmer
Copy link

The same happens with a Promise.reject() in beforeAll()

@thomasbrooks4
Copy link

Bump. Update? Fairly frustrating for a commonly used hook.

@github-actions
Copy link

This issue is stale because it has been open for 1 year with no activity. Remove stale label or comment or this will be closed in 30 days.

@github-actions github-actions bot added the Stale label Feb 17, 2023
@github-actions
Copy link

This issue was closed because it has been stalled for 30 days with no activity. Please open a new issue if the issue is still relevant, linking to this one.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Mar 19, 2023
@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

6 participants